Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump MSRV to 1.63.0 #960

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Bump MSRV to 1.63.0 #960

merged 3 commits into from
Jun 18, 2024

Conversation

kinto-b
Copy link
Contributor

@kinto-b kinto-b commented Jun 17, 2024 •
edited by Philippe-Cholet
Loading

Resolves #959

@codecov Codecov
Copy link

codecov bot commented Jun 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.53%. Comparing base (6814180) to head (dc6c181).
Report is 104 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #960      +/-   ##
==========================================
+ Coverage   94.38%   94.53%   +0.14%     
==========================================
  Files          48       49       +1     
  Lines        6665     7060     +395     
==========================================
+ Hits         6291     6674     +383     
- Misses        374      386      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Philippe-Cholet
Philippe-Cholet requested changes Jun 18, 2024
View reviewed changes
Copy link
Member

@Philippe-Cholet Philippe-Cholet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast, thanks! Not much to change.

PS: Changed your initial message to automatically close the associated issue.

src/concat_impl.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
tests/quick.rs Show resolved Hide resolved
@kinto-b
Copy link
Contributor Author

kinto-b commented Jun 18, 2024

Haha, I've got a bit of free time on my hands at the moment (moved country and between jobs) and wasn't up to much when I saw your @ :)

Thanks as always for your help!

@Philippe-Cholet Philippe-Cholet added this to the next milestone Jun 18, 2024
@Philippe-Cholet Philippe-Cholet added this pull request to the merge queue Jun 18, 2024
Merged via the queue into rust-itertools:master with commit 9f5256f Jun 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Philippe-Cholet Philippe-Cholet Philippe-Cholet approved these changes

Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.

Increase MSRV to 1.63
2 participants
@kinto-b @Philippe-Cholet