Skip to content

Commit

Permalink
Mention label has-merge-commits
Browse files Browse the repository at this point in the history
  • Loading branch information
fmease authored and Noratrieb committed Jan 14, 2024
1 parent 8042fcc commit fc36182
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions src/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -243,16 +243,20 @@ The CI will also run tidy and will fail if tidy fails.
Rust follows a _no merge-commit policy_, meaning, when you encounter merge
conflicts you are expected to always rebase instead of merging. E.g. always use
rebase when bringing the latest changes from the master branch to your feature
branch.
branch. If your PR contains merge commits, it will get marked as `has-merge-commits`.
Once you have removed the merge commits, e.g., through an interactive rebase, you
should remove the label again:

@rustbot label -has-merge-commits

See [this chapter][labeling] for more details.

If you encounter merge conflicts or when a reviewer asks you to perform some
changes, your PR will get marked as `S-waiting-on-author`. When you resolve
them, you should use `@rustbot` to mark it as `S-waiting-on-review`:

@rustbot label -S-waiting-on-author +S-waiting-on-review

See [this chapter][labeling] for more details.

GitHub allows [closing issues using keywords][closing-keywords]. This feature
should be used to keep the issue tracker tidy. However, it is generally preferred
to put the "closes #123" text in the PR description rather than the issue commit;
Expand Down

0 comments on commit fc36182

Please sign in to comment.