Make the null import descriptor name unique to the import library #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaoliello
approved these changes
Aug 19, 2024
|
Thanks! Published as v0.4.1. |
|
Great! I've updated my rustc PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the name of the null import descriptor is less special than I had assumed. We can use anything. So this makes the null import descriptor incorporate the name of the library to avoid any conflicts when using
/WHOLEARCHIVE. This is done only if thewhole_archive_compatoption is set.I've tested this locally with different targets and both MSVC and LLVM can use the import libraries it generates. Also this approach passes Rust's CI.
Closes #22 because we reuse the same flag for essentially the same purpose and renaming an argument is not a semver break.