-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update backtrace Debug formatting #261
Conversation
…mbol" This reverts commit 46644de.
…frame field to BacktraceFrameFmt, and resorted back to previous method of printing just with some new formatting.
Hopefully fix certain CI build errors
Thanks for the PR here @0paIescent! The changes in rust-lang/rust#65280 all sound reasonable to me, but I might recommend organizing this a bit differently. In the standard library we want to continue to have two implementations for Does that make sense? With all that in place I think we'll want to update libstd to have a new |
Of course! You make some great points, I'll definitely keep those in mind when I refactor these changes. Thanks for the tips! |
Hello, it has been a while since this PR was opened and it has accumulated a number of conflicts and is likely to have a different reception in the year 2024. So, I am closing it for now, but if you wish to pursue this again, please feel free to open a new PR. |
Part of the PR for an issue over at rust-lang/rust here. Once this gets merged here, I'll submit the PR over there, just want to make sure everything integrates properly first.