Formatting of std::backtrace::Backtrace #284
Conversation
…mbol" This reverts commit 46644de.
…frame field to BacktraceFrameFmt, and resorted back to previous method of printing just with some new formatting.
There was a problem hiding this comment.
Thanks!
I think though that we'll want to keep around the old formatting for Display, but add in new formatting for Debug, or at least that's how I've understood rust-lang/rust#65280.
For now in terms of implementation I'd prefer to avoid regressing users of the backtrace crate itself too much, so I think we should leave the Debug impl functionally as-is, but we could enhance the formatter to support both the display and debug style formatting of libstd. (we could then add an adapter of some kind to print a backtrace::Backtrace in the Debug style of libstd too.
| @@ -43,7 +43,7 @@ jobs: | |||
| os: windows-latest | |||
| rust: nightly-i686-gnu | |||
| steps: | |||
| - uses: actions/checkout@v1 | |||
| - uses: actions/checkout@master | |||
There was a problem hiding this comment.
How come these revisions changed? (I don't think current syntax works unless it's v1)
There was a problem hiding this comment.
I was reading the existing PR on master and I swapped a few on accident, I'm planning on just force pushing to this branch with a new change from scratch so just ignore everything that's currently pushed
|
The more i look at this the more I think the debug formatting should all be implemented in std, gonna close this for now, may reopen later. |
gonna try to push this over the finish line
cc rust-lang/rust#65280