Utilize cfg_attr instead of a build script. #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Odd that AppVeyor succeeded, looking into the failure. |
This also updates serde to a more recent version (1.0).
Mark-Simulacrum
force-pushed
the
serde-derive
branch
from
4ca3135 to
18e1931
Compare
|
👍 Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also updates serde to a more recent version (1.0).
cfg_attris now expanded withinclude!(though we don't use it anymore) since rust-lang/rust#33706.serde_derivealso supportscfg_attr, so we should be fine in that respect as well.This is, I believe, a breaking change due to the bump in the serde dependency from 0.8 to 1.0.