Update other GitHub actions #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That message is just annoying spam for our purposes.
|
It seems it doesn't want to use a version of this workflow that isn't the version on master. |
ChrisDenton
reviewed
Sep 14, 2024
| @@ -61,6 +61,7 @@ jobs: | |||
| run: | | |||
| # Bootstrap config | |||
| cat <<EOF > config.toml | |||
| change-id = 9999999 | |||
There was a problem hiding this comment.
This doesn't seem to have worked? Maybe it's not seeing the config.toml file for some reason?
There was a problem hiding this comment.
It's also using actions/checkout@v3. It won't use the workflow file changes until they're merged.
There was a problem hiding this comment.
Oh I see! I get what you were saying now. This looks right to me so I guess we'll merge and see?
ChrisDenton
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We started using download-artifact@v4.1.7 in #663 but the rest weren't so security critical so dependabot didn't bump them. Not having them "just" breaks a workflow or two. So bump them.