Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl trait capture rules blog post #1392

Merged
merged 13 commits into from
Sep 6, 2024
Merged

impl trait capture rules blog post #1392

merged 13 commits into from
Sep 6, 2024

Conversation

nikomatsakis
Copy link
Contributor

@nikomatsakis nikomatsakis commented Sep 4, 2024 •
edited
Loading

Explain the changes coming for -> impl Trait in Rust 2024. Also gives a heads-up about the new use syntax.

@nikomatsakis
Copy link
Contributor Author

cc @jackh726 @traviscross @compiler-errors @tmandry

CleanCut
CleanCut reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@CleanCut CleanCut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just having fun reading and thought I'd indulge my inner reviewer for a bit. 😆

Inconsistent word usage:

  • "return position" vs "return-position"
  • "impl trait" vs "impl trait" (with backticks)

posts/2024-09-05-impl-trait-capture-rules.md Outdated Show resolved Hide resolved
posts/2024-09-05-impl-trait-capture-rules.md Outdated Show resolved Hide resolved
posts/2024-09-05-impl-trait-capture-rules.md Show resolved Hide resolved
tmandry
tmandry reviewed Sep 6, 2024
View reviewed changes
posts/2024-09-05-impl-trait-capture-rules.md Outdated Show resolved Hide resolved
posts/2024-09-05-impl-trait-capture-rules.md Outdated Show resolved Hide resolved
posts/2024-09-05-impl-trait-capture-rules.md Outdated Show resolved Hide resolved
posts/2024-09-05-impl-trait-capture-rules.md Outdated Show resolved Hide resolved
posts/2024-09-05-impl-trait-capture-rules.md Show resolved Hide resolved
posts/2024-09-05-impl-trait-capture-rules.md Outdated Show resolved Hide resolved
nikomatsakis and others added 2 commits September 6, 2024 13:09
@nikomatsakis @lqd
Update posts/2024-09-05-impl-trait-capture-rules.md
7df9596 
Co-authored-by: Rémy Rakic <remy.rakic+github@gmail.com>
@nikomatsakis
s/datums/data/
3cbc57d
tmandry
tmandry approved these changes Sep 6, 2024
View reviewed changes
posts/2024-09-05-impl-trait-capture-rules.md Outdated Show resolved Hide resolved
@nikomatsakis @tmandry
Update posts/2024-09-05-impl-trait-capture-rules.md
1cc38d0 
Co-authored-by: Tyler Mandry <tmandry@gmail.com>
@nikomatsakis nikomatsakis merged commit 8e26919 into rust-lang:master Sep 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@folkertdev folkertdev folkertdev left review comments

@CleanCut CleanCut CleanCut left review comments

@compiler-errors compiler-errors compiler-errors left review comments

@VorpalBlade VorpalBlade VorpalBlade left review comments

@lqd lqd lqd left review comments

@tmandry tmandry tmandry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nikomatsakis @lqd @tmandry @VorpalBlade @compiler-errors @CleanCut @folkertdev