Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.25 announcement #237

Merged
merged 4 commits into from
Mar 29, 2018
Merged

1.25 announcement #237

merged 4 commits into from
Mar 29, 2018

Conversation

steveklabnik
Copy link
Member

This is the first chunk of the 1.25 release notes; I'm going to finish it tomorrow, but in the interest of giving people as much time to review as possible, here's the first half.

@rust-highfive
Copy link

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

Notable Cargo changes:

That's what I see in the diff at least!

@steveklabnik
Copy link
Member Author

steveklabnik commented Mar 22, 2018 via email

This can reduce some repetition, and make things a bit more clear.

There are two big documentation changes in this release: first, [Rust By
Example is now included on doc.rust-lang.org]! We'll be redirecing the old
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/redirecing/redirecting


Second, back in Rust 1.23, we talked about the change from Hoedown to
pulldown-cmark. In Rust 1.25, pulldown-cmark is now the default rendering.
After years, we have finally removed the last bit of C from rustdoc, and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be correct, but "After years" sounds a little odd -- maybe remove entirely? I can't think of what would go well there...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, if you think it is. idk.

of your `struct`s:

```rust
struct NotAligned(i32);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Er, this is by-default aligned I think? It's just aligned in a somewhat unspecified (not sure on this. might be specified) way.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah good point, it's not specifically aligned, or like, compiler chooses how to align it. hrm.

@steveklabnik
Copy link
Member Author

I am not sure what to rename the struct to...


Many users love `cargo doc`, a way to generate local documentation for their
Cargo projects. [It's getting a huge speed
bump](https://github.com/rust-lang/cargo/pull/5013) in this release, as now,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is incorrect.

`libcore` has [gained a `time` module](https://doc.rust-lang.org/core/time/),
containing the `Duration` type previously only available in `libstd`.

Additionally, the `new`, `from_secs`, `from_milis`, `from_micros`, and `from_nanos`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from_micros and from_nanos are unstable. Does it make sense to mention them here if you can't use them on stable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didn't realize this; it was in the changelog

@Mark-Simulacrum Mark-Simulacrum changed the title first part of 1.25 announcement 1.25 announcement Mar 29, 2018
@Mark-Simulacrum Mark-Simulacrum merged commit 0a9be40 into gh-pages Mar 29, 2018
@aidanhs aidanhs deleted the 1.25-announcement branch March 29, 2018 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants