inline-asm: Update for new style #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-lang/rust#73364 implemented support for providing multiple lines of assembly as separate arguments to `asm!`; update the blog post to use that new syntax, so that people who find it will use that style as an example.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
cc @Amanieu |
|
@joshtriplett LGTM, should I wait for @Amanieu's review or should I just merge it? |
|
I don't think we should indent the asm code inside the strings (i.e. keep the labels and instructions on the same indent level). |
|
@Amanieu I don't have a strong preference, I just wanted to show the ability to do so. Happy to change it. |
|
You should update the playground link as well. |
|
@Amanieu Good catch, done. |
|
LGTM |
|
Thank you for your PR! |
jackh726
pushed a commit
to jackh726/blog.rust-lang.org
that referenced
this pull request
Jul 26, 2021
* inline-asm: Update for new style rust-lang/rust#73364 implemented support for providing multiple lines of assembly as separate arguments to `asm!`; update the blog post to use that new syntax, so that people who find it will use that style as an example. * inline-asm: Outdent * inline asm: Update play link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/rust#73364 implemented support for
providing multiple lines of assembly as separate arguments to
asm!;update the blog post to use that new syntax, so that people who find it
will use that style as an example.