1.45.2 post #661
1.45.2 post #661
Conversation
|
r? @rust-lang/release |
posts/2020-07-31-Rust-1.45.2.md
Outdated
| some traits for better error messages. Trait objects of `SliceIndex`, `Index`, | ||
| and `IndexMut` are affected by this bug. | ||
|
|
||
| ## Bindings in tuple-patterns |
There was a problem hiding this comment.
The bug actually manifested in a slice pattern.
There was a problem hiding this comment.
Well, the backported fix was for tuple patterns, and the regression was in a slice pattern. So we're going back to the status quo from 1.45.0, and I guess that ICE will re-emerge for tuples.
There was a problem hiding this comment.
Hm, I think the bug is something like "slice patterns in tuple patterns" or something like that. I'm not sure how to pinpoint it.
There was a problem hiding this comment.
Oh, because Option::Some(_) is a tuple variant? OK, that makes sense, and I just checked that there's no issue for slice patterns alone.
There was a problem hiding this comment.
Maybe "Nested bindings in tuple patterns"?
There was a problem hiding this comment.
The condition leads me to believe it needs to be a tuple struct (or tuple enum variant, I guess) specifically with a .. pattern bound to a variable in it. Saying all of that in the heading seems too verbose, though. Perhaps "Tuple patterns containing bindings to .."? That also feels rather long.
Co-authored-by: Josh Stone <cuviper@gmail.com>
posts/2020-07-31-Rust-1.45.2.md
Outdated
| release: true | ||
| --- | ||
|
|
||
| The Rust team is happy to announce a new version of Rust, 1.45.2. Rust is a |
There was a problem hiding this comment.
I'm not sure how I feel about the wording of "happy to announce". In a way, the release is a result of previous mistakes, so perhaps it's not something we should be celebrating?
There was a problem hiding this comment.
I think this is fine - we are in some sense happy to fix the bug at least. If you have alternative suggestions though I'd be happy to consider them.
There was a problem hiding this comment.
The Rust team announces...
I was also considering this general direction, though I had the impression that the correct tense would be "The Rust team is announcing". I'm not a native speaker, though 🙃
There was a problem hiding this comment.
Pushed an update.
Co-authored-by: Josh Stone <cuviper@gmail.com>
This is targeting tomorrow right now, but that may be adjusted in the future.