-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial 1.52.0 post #822
Conversation
Ok, made some adjustments - I feel like it's missing some structure (maybe headings or so) but then the sections get really small, not sure what to do about that. Maybe just some better flow would work. |
Wow, I didn't know the That leaves |
Heh, I don't use clippy ~at all myself so it's not really that big a deal in my eyes, but I can uplift it a bit into its own section. I think doing that will make it reasonable to drop the loop {} thing, it's not really a big deal, mostly there as a "well nothing else". |
Oh yeah, this is a pretty big thing for Clippy. This bug was around for years and it is an example of successful collaboration between the cargo and the Clippy team to finally get this fixed. |
Ok, I changed this to focus on just Clippy -- I am open to suggestions further though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clippy part LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks Mark for writing the post this cycle!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was supposed to be an approval 😅
d45f2af
Co-authored-by: Pietro Albini <pietro@pietroalbini.org>
This cycle didn't have a lot of notable stabilizations or changes in the language or standard library so I ended up keeping things pretty concise. If someone has particular things they'd like to highlight that seems positive - though I'd rather not devote too much time to something minor - we can definitely iterate further.
r? @rust-lang/release
cc @rust-lang/core