Creating a diff of the comments from nostarch #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carols10cents
force-pushed
the
nostarch-comments
branch
from
c47d6fe
to
6c3899c
Compare
carols10cents
force-pushed
the
nostarch-comments
branch
from
6c3899c
to
45cb1ff
Compare
| @@ -26,9 +26,12 @@ well as how they work behind the scenes. | |||
| ## Contributing to the book | |||
|
|
|||
| This book is open source. If you find an error, please don’t hesitate to file an | |||
| issue or send a pull request [on GitHub]. | |||
| issue or send a pull request on GitHub at *https://github.com/rust-lang/book*. | |||
There was a problem hiding this comment.
the only issue with this link style is that it's terrible SEO. Whatever. We'll make it work 😄
There was a problem hiding this comment.
I've got some ideas:
| require. In this case, we’ve specified the `rand` crate with the semantic | ||
| version specifier `0.3.14`. Cargo understands [Semantic Versioning][semver], a | ||
| version specifier `0.3.14`. Cargo understands [Semantic Versioning][semver](semver), a |
There was a problem hiding this comment.
I'm not sure what Liz is trying to do on this line... I mean, we need to handle the link, but I think she's also adding a parenthetical to point out the common shortening of semver (that I think we do use later, so that would be good) but didn't put a space in between?
AbrarNitk
pushed a commit
to FifthTry/rust-book
that referenced
this pull request
Jun 2, 2021
io.std.results 등의 standard crate 참조 url 수정. rust-lang#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not going to merge, just to have a place to see what nostarch's comments were and discuss them.
Ok, i think I've gotten a pretty good diff now.