Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include compiler crashes in ICE defintion #78

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

Alexendoo
Copy link
Member

This matches the definition used in glacier, which includes exit status
101 without an accompanying diagnostic (such as rust-lang/rust#21599), and when
rustc is killed by a signal (rust-lang/rust#13368)

This also means no processing modes are capturing stdio, but I didn't
remove it as it may be desired for the regex features discussed in #53

This matches the definition [used in glacier], which includes exit status
101 without an accompanying diagnostic (such as rust-lang/rust#21599), and when
rustc is killed by a signal (rust-lang/rust#13368)

This also means no processing modes are capturing stdio, but I didn't
remove it as it may be desired for the regex features discussed in rust-lang#53

[used in glacier]: https://github.com/rust-lang/glacier/blob/77029d8e7f755bd95913d3c741738674d5ccadc3/src/lib.rs#L51-L56
@spastorino spastorino merged commit 02bcfe9 into rust-lang:master Apr 20, 2020
@Alexendoo Alexendoo deleted the ice-status-code branch April 20, 2020 14:32
@pnkfelix
Copy link
Member

pnkfelix commented May 15, 2020

I don't think this PR was quite right; it treats error code 101 as a unique identifier for ICE's, but even normal static errors from rustc cargo (driving rustc) will produce that same error code, I believe.

This mistake ends up breaking certain uses of --regress=ice, such as one I'm trying to include in my test suite as part of PR #88.

I'm going to revert this PR as part of PR #88 and open an issue to re-add its effects in a manner compatible with --regress=ice

@pnkfelix
Copy link
Member

I do see that Glacier is using this same logic (link taken from commit). So either I'm wrong or glacier is wrong. Hmm.

@pnkfelix
Copy link
Member

pnkfelix commented May 15, 2020

Ah, Glacier invokes rustc directly. So maybe Glacier's logic is correct for direct rustc invocations, but not appropriate for cargo invocations?

Update: Yes, experimentation indicates that is what is going on.

@Alexendoo
Copy link
Member Author

Ah yeah sorry I didn't test cargo directly, I was using it with --script rustc -- file and assumed it would be the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants