Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo doc ignores changes to files not added to git repository #1575

Closed
ghost opened this issue May 4, 2015 · 0 comments · Fixed by #1584
Closed

cargo doc ignores changes to files not added to git repository #1575

ghost opened this issue May 4, 2015 · 0 comments · Fixed by #1584

Comments

@ghost
Copy link

ghost commented May 4, 2015

As the title says really, when I modify a file that git doesn't know about and run cargo doc, cargo doesn't realise it has changed and doesn't bother to update the docs.

Reproduction:

  • cargo new
  • Add doc comment to src\lib.rs
  • cargo doc - docs are built
  • Modify doc comment
  • cargo doc - docs are not built
  • git add src\lib.rs
  • cargo doc - docs are built
  • Modify documentation
  • cargo doc - docs are built
alexcrichton added a commit to alexcrichton/cargo that referenced this issue May 5, 2015
@alexcrichton
Scan untracked files in git for packaging/deps
a8e9ce2 
Closes rust-lang#797
Closes rust-lang#1575
@alexcrichton alexcrichton mentioned this issue May 5, 2015
Merged
bors added a commit that referenced this issue May 5, 2015
@bors
Auto merge of #1584 - alexcrichton:issue-797, r=brson
aa8ee2d 
Closes #797
Closes #1575 

This is a reopening of #1170 but I see the two closed issues as important enough that this needs to land in some form or another, and I'm more comfortable with always taking into account untracked files than only if there isn't a commit yet.
@bors bors closed this as completed in #1584 May 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Scan untracked files in git for packaging/deps alexcrichton/cargo
0 participants