Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about crates named with Rust keywords #2699

Closed
bbatha opened this issue May 16, 2016 · 0 comments · Fixed by #2707
Closed

Warn about crates named with Rust keywords #2699

bbatha opened this issue May 16, 2016 · 0 comments · Fixed by #2707
Labels
A-diagnostics Area: Error and warning messages generated by Cargo itself.

Comments

@bbatha
Copy link

bbatha commented May 16, 2016

I made a crate called "pub", and was unable to import it into a dependent project because of the keyword clash. Some sort of warning or error from cargo would be appreciated.

@alexcrichton alexcrichton added the A-diagnostics Area: Error and warning messages generated by Cargo itself. label May 16, 2016
sbeckeriv added a commit to sbeckeriv/cargo that referenced this issue May 17, 2016
Dearest Reviewer,

This pull request extends the banned list of project names to include
all of the current keywords for rust. I got the list of keywords from
https://doc.rust-lang.org/grammar.html#keywords . This
closes rust-lang#2699 . The original ticket said warn but I figured how test is
handled is most likely how all banned names should be handled.

Oddly enough a few keywords have made their way to the crates.io. fn and
proc are both examples I found spot checking keywords. I do not there is
any action to take on those crates.

Thanks
Becker
bors added a commit that referenced this issue May 17, 2016
Ban keywords from crate names

Dearest Reviewer,

This pull request extends the banned list of project names to include
all of the current keywords for rust. I got the list of keywords from
https://doc.rust-lang.org/grammar.html#keywords . This
closes #2699 . The original ticket said warn but I figured how test is
handled is most likely how all banned names should be handled.

Oddly enough a few keywords have made their way to the crates.io. fn and
proc are both examples I found spot checking keywords. I do not there is
any action to take on those crates.

Thanks
Becker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Error and warning messages generated by Cargo itself.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants