-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mismatch against yanked version doesn't inform user about yank #4260
Comments
Looks like the error hasn't improved in the intervening time #!/usr/bin/env nargo
```cargo
[dependencies]
bincode = "=1.0.0-alpha7" fn main () {}
@Eh2406 how bad would this be to improve the error in this case? |
The resolver is reporting that the package doesn't exist, because it got filtered out and a much lower level of abstraction. |
Not sure I should open a separate issue, but relatedly, the error from |
Allowing |
The user likely intended what they said and we should tell them why it didn't work. Rejected versions also imply alt versions below them. Fixes rust-lang#4260
The user likely intended what they said and we should tell them why it didn't work. Rejected versions also imply alt versions below them. Fixes rust-lang#4260
…14923) ### What does this PR try to resolve? The user likely intended what they said and we should tell them why it didn't work. Rejected versions also imply alt versions below them. Fixes #4260 In changing the errors from alt-versions to rejected-versions, I found part of the old error message was better and changed the message introduced in #14897 from matching alt-names to alt-versions. This includes the test for #14921. The "fix" was done before this because as it was part of the refactors in prep for this. ### How should we test and review this PR? ### Additional information Next steps after this are to still produce an `IndexSummary::Unsupported` even if there are deserialization errors, so long as we know the name and version which should take care of #10623 and #14894.
Depending on
bincode = "1.0.0-alpha7"
produces the following error:It doesn't mention the fact that there is a
1.0.0-alpha7
, but it has been yanked.This can leave the user confused about whether they mistyped something, or they are just trying to depend on a yanked version.
Semi-related: https://github.com/onur/docs.rs/issues/112#issuecomment-313868337
The text was updated successfully, but these errors were encountered: