Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The publish-lockfile option is not usable #5427

Closed
phil-opp opened this issue Apr 28, 2018 · 1 comment · Fixed by #5603
Closed

The publish-lockfile option is not usable #5427

phil-opp opened this issue Apr 28, 2018 · 1 comment · Fixed by #5603
Labels
C-bug Category: bug

Comments

@phil-opp
Copy link
Contributor

The publish-lockfile manifest key was introduced in #5093 as a nightly feature. However, it is not usable at the moment because nightly-only features are not allowed on crates.io:

> cargo publish
error: cannot publish crates which activate nightly-only cargo features to crates.io

cc @alexcrichton
@alexcrichton alexcrichton added the C-bug Category: bug label Apr 28, 2018
@oli-obk
Copy link
Contributor

oli-obk commented Jun 3, 2018

The same goes for cargo-features = ["edition"], which means that there will be no more published clippy versions until this issue is resolved

@oli-obk oli-obk mentioned this issue Jun 3, 2018
Closed
@matklad matklad mentioned this issue Jun 3, 2018
Merged
bors added a commit that referenced this issue Jun 7, 2018
@bors
Auto merge of #5603 - matklad:publish-nightly-features, r=matklad
e2348c2 
Allow publishing crates with nightly features

closes #5427.

cc @rust-lang/cargo: I remember a vigorous debate over publishing crates with nightly Cargo features, but I can't recollect our exact plan of action. The discussion is logged here: https://paper.dropbox.com/doc/Unstable-Cargo-features-JBYMdsUYcO3FyW8Ubkjoz.

I think we just need to allow to publish crates with unstable cargo features, for the same reason we allow unstable rust features: you need explicit opt-in, even for deps. This is covered by Cargo tests: https://github.com/rust-lang/cargo/blob/9f097787b04b06cdde4fc42b26a531b22c1b37a6/tests/testsuite/cargo_features.rs#L115-L215.

I am not sure if we have ever implemented crates.io side of validation?
@bors bors closed this as completed in #5603 Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow publishing crates with nightly features matklad/cargo
3 participants
@alexcrichton @oli-obk @phil-opp