Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetch_platform_specific_dependencies etc fails for non-x86 architectures #5864

Closed
infinity0 opened this issue Aug 5, 2018 · 3 comments
Closed

fetch_platform_specific_dependencies etc fails for non-x86 architectures #5864

infinity0 opened this issue Aug 5, 2018 · 3 comments

Comments

@infinity0
Copy link
Contributor

From #5349 @bmwill
See e.g.
@bmwill
Copy link
Contributor

bmwill commented Aug 6, 2018

This doesn't seem to be directly due to the fetch tests introduced in #5349, but rather due to the fact that the cross_compile module doesn't support platforms other than x86 (https://github.com/rust-lang/cargo/blob/master/tests/testsuite/support/cross_compile.rs#L111). Looking at some of the other tests in the testsuite that rely on the cross_compile module, they simply do an early return if it has been disabled (e.g. https://github.com/rust-lang/cargo/blob/master/tests/testsuite/install.rs#L1049). So it looks like the simplest way to fix this would be to do the same with the two failing fetch tests. Give me a bit and I'll write up a short PR for that.

@bmwill bmwill mentioned this issue Aug 6, 2018
Merged
bors added a commit that referenced this issue Aug 6, 2018
@bors
Auto merge of #5870 - bmwill:fix-fetch-target-tests, r=alexcrichton
97a988e 
fetch: skip target tests when cross_compile is disabled

It was reported in #5864 that the fetch-by-target tests fail when run on a non-x86 platform.  This is due to the cross_compile module being disabled when running on non-x86 platforms.  Fix this by skipping the two fetch tests which rely on the cross_compile module, when cross_compile has been disabled.

Signed-off-by: Brandon Williams <bmwill@google.com>
@bmwill
Copy link
Contributor

bmwill commented Aug 6, 2018

Forgot to include the special phrase "fixes #5864" in #5870

@alexcrichton would you mind closing this issue? Unless you'd like to wait for @infinity0 to verify that #5870 indeed fixes the issue on their platform.

@alexcrichton
Copy link
Member

Sure thing sounds good to me! If it's still an issue we can always reopen!

raspbian-autopush pushed a commit to raspbian-packages/cargo that referenced this issue Aug 22, 2018
@copyninja
Disable fetch tests to allow build on arm and ppc architecture
04bc580 
These tests are disabled to allow building on release architecture.
Bug: rust-lang/cargo#5864
Last-Update: 2018-08-05

Gbp-Pq: Name 2005_disable_fetch_cross_tests.patch
raspbian-autopush pushed a commit to raspbian-packages/cargo that referenced this issue Aug 22, 2018
@copyninja @infinity0
Disable fetch tests to allow build on arm and ppc architecture
9d7c2d1 
These tests are disabled to allow building on release architecture.
Bug: rust-lang/cargo#5864
Last-Update: 2018-08-05

Gbp-Pq: Name 2005_disable_fetch_cross_tests.patch
raspbian-autopush pushed a commit to raspbian-packages/cargo that referenced this issue Aug 22, 2018
@copyninja
Disable fetch tests to allow build on arm and ppc architecture
fd49062 
These tests are disabled to allow building on release architecture.
Bug: rust-lang/cargo#5864
Last-Update: 2018-08-05

Gbp-Pq: Name 2005_disable_fetch_cross_tests.patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @infinity0 @bmwill