You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The test build_script_with_dynamic_native_dependency does not seem to be working as it was originally intended. I was going to fix it myself, but there are too many changes that I don't understand. There are two primary issues:
This line in the test points to a non-existing path:
Test was changed to use a workspace in fix dynamic search path for build scripts #3974 which resulted in the build script emitting a path that does not exist. That PR also changed it so that linker paths must be prefixes of the target/debug directory, so you can't just switch it back to a non-workspace.
It's not clear to me how #3974 was supposed to work. It's also not clear if add_plugin_deps is even needed anymore. I would think all plugin dylibs should already live in the deps dir which is already included in the LD_LIBRARY_PATH, so I don't know why add_plugin_deps exists.
The text was updated successfully, but these errors were encountered:
Hm ok I think that test is basically the test for why add_plugin_deps exist. The addition of a workspace breaks the intention of the test, so those two projects definitely shouldn't be in the same workspace.
As for #1960 I dunno if it's necessary any more, if you can remove plugin = true and the test still works I'd remove it, it looks like one of those things where I just added it to keep something working at the time, and it may have been erroneous and/or no longer necessary
Fix add_plugin_deps-related tests.
These tests were modified in #3974 in such a way that they stopped testing the `add_plugin_deps` code path. The tests can't be directly reverted because #3651 changed it so that dylib paths must be within the root output directory. I compromised by just copying the dylib into `$OUT_DIR`.
Closes#6318.
The test
build_script_with_dynamic_native_dependency
does not seem to be working as it was originally intended. I was going to fix it myself, but there are too many changes that I don't understand. There are two primary issues:cargo/tests/testsuite/build_script.rs
Line 1440 in b3d0b2e
add_plugin_deps
does not cause any errors):cargo/src/cargo/core/compiler/mod.rs
Lines 517 to 542 in b3d0b2e
The history for this test:
add_plugin_deps
added in Remove the deprecated build command infrastructure #1195.plugin = true
in Don't link build scripts dynamically #1960. ← This one I particularly don't understand.target/debug
directory, so you can't just switch it back to a non-workspace.It's not clear to me how #3974 was supposed to work. It's also not clear if
add_plugin_deps
is even needed anymore. I would think all plugin dylibs should already live in thedeps
dir which is already included in the LD_LIBRARY_PATH, so I don't know whyadd_plugin_deps
exists.The text was updated successfully, but these errors were encountered: