Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake is no longer required? #6367

Closed
RandomInsano opened this issue Dec 2, 2018 · 3 comments
Closed

cmake is no longer required? #6367

RandomInsano opened this issue Dec 2, 2018 · 3 comments

Comments

@RandomInsano
Copy link
Contributor

Problem
The README claims I need cmake. I do not have cmake. Cargo built anywhoo.

Mainly curious where cmake is still needed and if the docs should be made more specific or refreshed.

Steps

  1. Install a clean copy of macOS Mojave
  2. Install rust via rustup
  3. Install dev tools via xcode-select
  4. Install Homebrew, then openssl
  5. Clone, then build cargo

Possible Solution(s)
Be specific on which OSes require cmake?
@dwijnand
Copy link
Member

dwijnand commented Dec 2, 2018

It was added when there was a makefile, so probably not anymore! PR?

RandomInsano added a commit to RandomInsano/cargo that referenced this issue Dec 2, 2018
@RandomInsano
Remove cmake as a requirement
3b0f31e 
No longer needed as outlined in rust-lang#6367
@RandomInsano RandomInsano mentioned this issue Dec 2, 2018
Merged
@RandomInsano
Copy link
Contributor Author

And so the PR did get created:
#6368

bors added a commit that referenced this issue Dec 2, 2018
@bors
Auto merge of #6368 - RandomInsano:patch-1, r=alexcrichton
e66ae61 
Remove `cmake` as a requirement

No longer needed as outlined in #6367
@RandomInsano
Copy link
Contributor Author

It’s been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RandomInsano @dwijnand