Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_cargo_compile_custom_build::code_generation is flaky on windows #867

Closed
alexcrichton opened this issue Nov 13, 2014 · 3 comments
Closed

Comments

@alexcrichton
Copy link
Member

I'm not really sure why, I'm ignoring it for now. The logs are:


failures:

---- test_cargo_compile_custom_build::code_generation stdout ----
    task 'test_cargo_compile_custom_build::code_generation' panicked at 'could not rm directory; path=C:\bot\slave\cargo-win-64\build\target\x86_64-pc-windows-gnu\cit\test-76\foo; original=couldn't recursively rmdir (rmdir_recursive failed; path=C:\bot\slave\cargo-win-64\build\target\x86_64-pc-windows-gnu\cit\test-76\foo; cause=couldn't unlink path (permission denied (OS Error 5: Access is denied.
    ); path=C:\bot\slave\cargo-win-64\build\target\x86_64-pc-windows-gnu\cit\test-76\foo\target\foo.exe))', tests\support\mod.rs:147

@alexcrichton
Copy link
Member Author

I haven't seen this in awhile, so closing.

@Eh2406
Copy link
Contributor

Eh2406 commented Jan 26, 2018

Maybe we haven't seen it in a while because of the #[cfg(not(windows))] // FIXME(#867)?

@alexcrichton
Copy link
Member Author

Heh we this has been closed for almost 3 years so I've certainly lost all context on this...

bors added a commit that referenced this issue May 29, 2023
Re-enable code_generation test on Windows

This re-enables the `code_generation` test on Windows. It was disabled some time ago (see #867), but I don't think whatever issue was hitting it is relevant now. There isn't anything unusual about this test, so I think it should be fine. I was unable to get it to fail after running a few thousand times, and also testing on CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants