Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify the description of quiet flag #10168

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Unify the description of quiet flag #10168

merged 2 commits into from
Dec 6, 2021

Conversation

Rustin170506
Copy link
Member

cc: #8928
I seem to have missed it.

@rust-highfive
Copy link

r? @alexcrichton

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 5, 2021
@ehuss
Copy link
Contributor

ehuss commented Dec 5, 2021

Thanks!

Would you mind maybe placing this into a arg_quiet function in command_prelude.rs and update all the sites that have opt("quiet") to call that instead? That can make it so that the help text doesn't need to be repeated everywhere.

@Rustin170506
Copy link
Member Author

Would you mind maybe placing this into a arg_quiet function in command_prelude.rs and update all the sites that have opt("quiet") to call that instead?

Done. Thank you for the suggestion!

@Rustin170506
Unify the description of quiet flag
d45c9ba 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@Rustin170506
Add arg_quiet
a3e3ff9 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@ehuss
Copy link
Contributor

ehuss commented Dec 6, 2021

Thanks, it looks much nicer!

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 6, 2021

📌 Commit a3e3ff9 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 6, 2021
@bors
Copy link
Collaborator

bors commented Dec 6, 2021

⌛ Testing commit a3e3ff9 with merge 40dc281...

@bors
Copy link
Collaborator

bors commented Dec 6, 2021

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 40dc281 to master...

@bors bors merged commit 40dc281 into rust-lang:master Dec 6, 2021
@bors bors mentioned this pull request Dec 6, 2021
Closed
@ehuss ehuss mentioned this pull request Dec 7, 2021
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 7, 2021
@matthiaskrgr
Rollup merge of rust-lang#91619 - ehuss:update-cargo, r=ehuss
5a0ee27 
Update cargo

8 commits in 294967c53f0c70d598fc54ca189313c86c576ea7..40dc281755137ee804bc9b3b08e782773b726e44
2021-11-29 19:04:22 +0000 to 2021-12-06 21:54:44 +0000
- Unify the description of quiet flag (rust-lang/cargo#10168)
- Stabilize future-incompat-report (rust-lang/cargo#10165)
- Support abbreviating `--release` as `-r` (rust-lang/cargo#10133)
- doc: nudge towards simple version requirements (rust-lang/cargo#10158)
- Upgrade clap to 2.34.0 (rust-lang/cargo#10164)
- Treat EOPNOTSUPP the same as ENOTSUP when ignoring failed flock calls. (rust-lang/cargo#10157)
- Add note about RUSTFLAGS removal from build scripts. (rust-lang/cargo#10141)
- Make clippy happy (rust-lang/cargo#10139)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 8, 2021
@matthiaskrgr
Rollup merge of rust-lang#91619 - ehuss:update-cargo, r=ehuss
c4bd406 
Update cargo

8 commits in 294967c53f0c70d598fc54ca189313c86c576ea7..40dc281755137ee804bc9b3b08e782773b726e44
2021-11-29 19:04:22 +0000 to 2021-12-06 21:54:44 +0000
- Unify the description of quiet flag (rust-lang/cargo#10168)
- Stabilize future-incompat-report (rust-lang/cargo#10165)
- Support abbreviating `--release` as `-r` (rust-lang/cargo#10133)
- doc: nudge towards simple version requirements (rust-lang/cargo#10158)
- Upgrade clap to 2.34.0 (rust-lang/cargo#10164)
- Treat EOPNOTSUPP the same as ENOTSUP when ignoring failed flock calls. (rust-lang/cargo#10157)
- Add note about RUSTFLAGS removal from build scripts. (rust-lang/cargo#10141)
- Make clippy happy (rust-lang/cargo#10139)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 8, 2021
@matthiaskrgr
Rollup merge of rust-lang#91619 - ehuss:update-cargo, r=ehuss
514260c 
Update cargo

8 commits in 294967c53f0c70d598fc54ca189313c86c576ea7..40dc281755137ee804bc9b3b08e782773b726e44
2021-11-29 19:04:22 +0000 to 2021-12-06 21:54:44 +0000
- Unify the description of quiet flag (rust-lang/cargo#10168)
- Stabilize future-incompat-report (rust-lang/cargo#10165)
- Support abbreviating `--release` as `-r` (rust-lang/cargo#10133)
- doc: nudge towards simple version requirements (rust-lang/cargo#10158)
- Upgrade clap to 2.34.0 (rust-lang/cargo#10164)
- Treat EOPNOTSUPP the same as ENOTSUP when ignoring failed flock calls. (rust-lang/cargo#10157)
- Add note about RUSTFLAGS removal from build scripts. (rust-lang/cargo#10141)
- Make clippy happy (rust-lang/cargo#10139)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 8, 2021
@matthiaskrgr
Rollup merge of rust-lang#91619 - ehuss:update-cargo, r=ehuss
75e2f79 
Update cargo

8 commits in 294967c53f0c70d598fc54ca189313c86c576ea7..40dc281755137ee804bc9b3b08e782773b726e44
2021-11-29 19:04:22 +0000 to 2021-12-06 21:54:44 +0000
- Unify the description of quiet flag (rust-lang/cargo#10168)
- Stabilize future-incompat-report (rust-lang/cargo#10165)
- Support abbreviating `--release` as `-r` (rust-lang/cargo#10133)
- doc: nudge towards simple version requirements (rust-lang/cargo#10158)
- Upgrade clap to 2.34.0 (rust-lang/cargo#10164)
- Treat EOPNOTSUPP the same as ENOTSUP when ignoring failed flock calls. (rust-lang/cargo#10157)
- Add note about RUSTFLAGS removal from build scripts. (rust-lang/cargo#10141)
- Make clippy happy (rust-lang/cargo#10139)
@ehuss ehuss added this to the 1.59.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Rustin170506 @rust-highfive @ehuss @bors @alexcrichton