Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the difference between CARGO_CRATE_NAME and CARGO_PKG_NAME #11576

Merged
merged 1 commit into from
Jan 22, 2023

Conversation

lu-zero
Copy link
Contributor

@lu-zero lu-zero commented Jan 13, 2023

Since I ended up asking on zulip.

@rustbot
Copy link
Collaborator

rustbot commented Jan 13, 2023

r? @epage

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 13, 2023
@lu-zero lu-zero force-pushed the clarify-pkg-vs-crate branch from d2ed4f6 to 202a0c8 Compare January 13, 2023 15:04
@lu-zero lu-zero force-pushed the clarify-pkg-vs-crate branch 3 times, most recently from d8a3951 to e678dbd Compare January 20, 2023 20:04
@lu-zero lu-zero force-pushed the clarify-pkg-vs-crate branch from e678dbd to fdcee03 Compare January 21, 2023 08:43
@lu-zero lu-zero force-pushed the clarify-pkg-vs-crate branch from fdcee03 to 9ba48bf Compare January 21, 2023 09:09
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 21, 2023

📌 Commit 9ba48bf has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2023
@bors
Copy link
Contributor

bors commented Jan 21, 2023

⌛ Testing commit 9ba48bf with merge 1dbcde2...

bors added a commit that referenced this pull request Jan 21, 2023
Clarify the difference between CARGO_CRATE_NAME and CARGO_PKG_NAME

Since I ended up asking on zulip.
@bors
Copy link
Contributor

bors commented Jan 21, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 21, 2023
@ehuss
Copy link
Contributor

ehuss commented Jan 21, 2023

@bors retry

ssh::invalid_github_key is flaky, I'm going to either fix it or disable it soon.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2023
@bors
Copy link
Contributor

bors commented Jan 21, 2023

⌛ Testing commit 9ba48bf with merge 2a6730c...

bors added a commit that referenced this pull request Jan 21, 2023
Clarify the difference between CARGO_CRATE_NAME and CARGO_PKG_NAME

Since I ended up asking on zulip.
@bors
Copy link
Contributor

bors commented Jan 21, 2023

💔 Test failed - checks-actions

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 21, 2023
@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 21, 2023
@weihanglo
Copy link
Member

@bors retry

#11609

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 22, 2023
@bors
Copy link
Contributor

bors commented Jan 22, 2023

⌛ Testing commit 9ba48bf with merge 96d5330...

@bors
Copy link
Contributor

bors commented Jan 22, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 96d5330 to master...

@bors bors merged commit 96d5330 into rust-lang:master Jan 22, 2023
bors pushed a commit to rust-lang-ci/rust that referenced this pull request Jan 25, 2023
11 commits in 985d561f0bb9b76ec043a2b12511790ec7a2b954..3c5af6bed9a1a243a693e8e22ee2486bd5b82a6c
2023-01-20 14:39:28 +0000 to 2023-01-24 15:48:15 +0000

- Add a note about verifying your email address on crates.io (rust-lang/cargo#11620)
- Improve CI caching by skipping mtime checks for paths in $CARGO_HOME (rust-lang/cargo#11613)
- test: Update for clap 4.1.3 (rust-lang/cargo#11619)
- Fix unused attribute on Windows. (rust-lang/cargo#11614)
- [Doc]: Added links to the `Target` section of the glossary for occurences of `target triple` (rust-lang/cargo#11603)
- feat: stabilize auto fix note (rust-lang/cargo#11558)
- Clarify the difference between CARGO_CRATE_NAME and CARGO_PKG_NAME (rust-lang/cargo#11576)
- Temporarily pin libgit2-sys. (rust-lang/cargo#11609)
- Disable network SSH tests on windows. (rust-lang/cargo#11610)
- fix(toml): Add `default-features` to `TomlWorkspaceDependency` (rust-lang/cargo#11409)
- doc(contrib): remove rls in release process (rust-lang/cargo#11601)
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 25, 2023
Update cargo

11 commits in 985d561f0bb9b76ec043a2b12511790ec7a2b954..3c5af6bed9a1a243a693e8e22ee2486bd5b82a6c 2023-01-20 14:39:28 +0000 to 2023-01-24 15:48:15 +0000

- Add a note about verifying your email address on crates.io (rust-lang/cargo#11620)
- Improve CI caching by skipping mtime checks for paths in $CARGO_HOME (rust-lang/cargo#11613)
- test: Update for clap 4.1.3 (rust-lang/cargo#11619)
- Fix unused attribute on Windows. (rust-lang/cargo#11614)
- [Doc]: Added links to the `Target` section of the glossary for occurences of `target triple` (rust-lang/cargo#11603)
- feat: stabilize auto fix note (rust-lang/cargo#11558)
- Clarify the difference between CARGO_CRATE_NAME and CARGO_PKG_NAME (rust-lang/cargo#11576)
- Temporarily pin libgit2-sys. (rust-lang/cargo#11609)
- Disable network SSH tests on windows. (rust-lang/cargo#11610)
- fix(toml): Add `default-features` to `TomlWorkspaceDependency` (rust-lang/cargo#11409)
- doc(contrib): remove rls in release process (rust-lang/cargo#11601)

r? `@ghost`
@ehuss ehuss added this to the 1.69.0 milestone Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants