Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --ignore-rust-version flag to cargo install #11859

Merged
merged 3 commits into from
Mar 17, 2023
Merged

Add --ignore-rust-version flag to cargo install #11859

merged 3 commits into from
Mar 17, 2023

Conversation

chaitanyav
Copy link
Contributor

@weihanglo Added the flag to cargo install
fixes #11718

@rustbot
Copy link
Collaborator

rustbot commented Mar 15, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @weihanglo (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-cli Area: Command-line interface, option parsing, etc. Command-install S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2023
weihanglo
weihanglo reviewed Mar 15, 2023
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, could you update the manpage of cargo install as well?
Please take this as a reference and follow this to regenerate docs.

@rustbot rustbot added the A-documenting-cargo-itself Area: Cargo's documentation label Mar 16, 2023
@rustbot rustbot added the A-cli-help Area: built-in command-line help label Mar 16, 2023
@chaitanyav
Copy link
Contributor Author

Hi, could you update the manpage of cargo install as well? Please take this as a reference and follow this to regenerate docs.

@weihanglo updated the docs

weihanglo
weihanglo approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

BTW, I found that --ignore-rust-version is missing in both zsh and bash completion for all commands having such flag. If you're still interested in helping out, I would appreciate a pull request for adding them. Could probably take this as a reference.

@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 16, 2023

📌 Commit 1c84d82 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2023
@bors
Copy link
Contributor

bors commented Mar 16, 2023

⌛ Testing commit 1c84d82 with merge afed1c4...

bors added a commit that referenced this pull request Mar 16, 2023
@bors
Auto merge of #11859 - chaitanyav:master, r=weihanglo
afed1c4 
Add --ignore-rust-version flag to cargo install

`@weihanglo` Added the flag to cargo install
fixes #11718
@bors
Copy link
Contributor

bors commented Mar 16, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 16, 2023
@weihanglo
Copy link
Member

The bug in nightly-2023-03-16 was fixed a couple hours ago on master and will be available tomorrow.

@chaitanyav
Copy link
Contributor Author

Looks good. Thanks!

BTW, I found that --ignore-rust-version is missing in both zsh and bash completion for all commands having such flag. If you're still interested in helping out, I would appreciate a pull request for adding them. Could probably take this as a reference.

sure, will make a pull request with bash and zsh completion

@rustbot rustbot added the A-completions Area: shell completions label Mar 16, 2023
@chaitanyav chaitanyav requested a review from weihanglo March 17, 2023 00:42
weihanglo
weihanglo approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

For whom wants to test the completion

zsh:

# under cargo project directory
fpath+=$PWD/src/etc
compinit

# test it
cargo rm <tab>

bash

# install any bash completion from your distro and source their init script
# e.g. brew install bash-completion && . "/path/to/pbash_completion.sh"

# under cargo project directory
. ./src/etc/cargo.bashcomp.sh

# test it
cargo rm <tab>

@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 17, 2023

📌 Commit f5c699e has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 17, 2023
@bors
Copy link
Contributor

bors commented Mar 17, 2023

⌛ Testing commit f5c699e with merge f2f4496...

@bors
Copy link
Contributor

bors commented Mar 17, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing f2f4496 to master...

@bors bors merged commit f2f4496 into rust-lang:master Mar 17, 2023
@weihanglo weihanglo mentioned this pull request Mar 21, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 22, 2023
@bors
Auto merge of rust-lang#109463 - weihanglo:update-cargo, r=weihanglo
6dc3999 
Update cargo

11 commits in 4a3c588b1f0a8e2dc8dd8789dbf3b6a71b02ed49..15d090969743630bff549a1b068bcaa8174e5ee3
2023-03-14 14:05:36 +0000 to 2023-03-21 17:54:28 +0000
- docs(contrib): Move higher level resolver docs into doc comments (rust-lang/cargo#11870)
- docs(contrib): Pull impl info out of architecture (rust-lang/cargo#11869)
- Update curl-sys (rust-lang/cargo#11871)
- Poll loop fixes (rust-lang/cargo#11624)
- clippy: warn `disallowed_methods` for `std::env::var` and friends (rust-lang/cargo#11828)
- Add --ignore-rust-version flag to cargo install (rust-lang/cargo#11859)
- Handle case mismatches when looking up env vars in the Config snapshot (rust-lang/cargo#11824)
- align semantics of generated vcs ignore files (rust-lang/cargo#11855)
- Add more information to wait-for-publish (rust-lang/cargo#11713)
- docs: Address warnings (rust-lang/cargo#11856)
- docs(contrib): Create a file overview in the nightly docs (rust-lang/cargo#11850)
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Mar 22, 2023
@bors
Auto merge of #109463 - weihanglo:update-cargo, r=weihanglo
0ed98a9 
Update cargo

11 commits in 4a3c588b1f0a8e2dc8dd8789dbf3b6a71b02ed49..15d090969743630bff549a1b068bcaa8174e5ee3
2023-03-14 14:05:36 +0000 to 2023-03-21 17:54:28 +0000
- docs(contrib): Move higher level resolver docs into doc comments (rust-lang/cargo#11870)
- docs(contrib): Pull impl info out of architecture (rust-lang/cargo#11869)
- Update curl-sys (rust-lang/cargo#11871)
- Poll loop fixes (rust-lang/cargo#11624)
- clippy: warn `disallowed_methods` for `std::env::var` and friends (rust-lang/cargo#11828)
- Add --ignore-rust-version flag to cargo install (rust-lang/cargo#11859)
- Handle case mismatches when looking up env vars in the Config snapshot (rust-lang/cargo#11824)
- align semantics of generated vcs ignore files (rust-lang/cargo#11855)
- Add more information to wait-for-publish (rust-lang/cargo#11713)
- docs: Address warnings (rust-lang/cargo#11856)
- docs(contrib): Create a file overview in the nightly docs (rust-lang/cargo#11850)
@ehuss ehuss added this to the 1.70.0 milestone Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@weihanglo weihanglo

Labels
A-cli Area: Command-line interface, option parsing, etc. A-cli-help Area: built-in command-line help A-completions Area: shell completions A-documenting-cargo-itself Area: Cargo's documentation Command-install S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.

add --ignore-rust-version for cargo install
5 participants
@chaitanyav @rustbot @weihanglo @bors @ehuss