Make clippy happy #11867
Closed
Make clippy happy #11867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
rustbot
added
the
S-waiting-on-review
|
Sorry I am confused. Did it complain? I thought tests were excluded from clippy check in CI. |
Yes. It only complains when I run it locally. Run |
weihanglo
reviewed
Mar 18, 2023
There was a problem hiding this comment.
I see. We have yet enable clippy for all cargo targets. There is a plan to clippyy all crates in this repository after it becomes a workspace (#11851).
Besides, I feel like we should allow std::env throughout the whole integration test. What do people think?
Yes, I agree. It makes sense to ignore it in tests. |
|
Closed by #11851 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #11828
r? @weihanglo