Fix Cargo warning about unused sparse configuration key #11930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing a credential lookup, Cargo deserializes the registry configuration and detects the registries.crates-io.protocol key as unused and issues a warning. This fixes the issue by adding the field to the struct
|
r? @weihanglo (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-registry-authentication
epage
reviewed
Apr 3, 2023
Comment on lines
+136
to
+137
| #[serde(rename = "protocol")] | ||
| _protocol: Option<String>, |
There was a problem hiding this comment.
Is there something we can do to avoid running into this issue in the future?
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Apr 3, 2023
Fix Cargo warning about unused sparse configuration key When doing a credential lookup, Cargo deserializes the registry configuration and detects the `registries.crates-io.protocol` key as unused and issues a warning: ``` warning: unused config key `registries.crates-io.protocol` in [..] ``` This fixes the issue by adding the field to the `RegistryConfig` struct.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Apr 3, 2023
Fix Cargo warning about unused sparse configuration key When doing a credential lookup, Cargo deserializes the registry configuration and detects the `registries.crates-io.protocol` key as unused and issues a warning: ``` warning: unused config key `registries.crates-io.protocol` in [..] ``` This fixes the issue by adding the field to the `RegistryConfig` struct.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
|
💡 This pull request was already approved, no need to approve it again. |
bors
added a commit
that referenced
this pull request
Apr 4, 2023
Fix Cargo warning about unused sparse configuration key When doing a credential lookup, Cargo deserializes the registry configuration and detects the `registries.crates-io.protocol` key as unused and issues a warning: ``` warning: unused config key `registries.crates-io.protocol` in [..] ``` This fixes the issue by adding the field to the `RegistryConfig` struct.
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 11, 2023
Update cargo 17 commits in 0e474cfd7b16b018cf46e95da3f6a5b2f1f6a9e7..7bf43f028ba5eb1f4d70d271c2546c38512c9875 2023-03-31 23:15:58 +0000 to 2023-04-10 16:01:41 +0000 - docs(pkgid): Consistently use @ (rust-lang/cargo#11956) - Fix credential token format validation. (rust-lang/cargo#11951) - Validate token on publish. (rust-lang/cargo#11952) - Clarify docs on `-C` that it appears before the command. (rust-lang/cargo#11947) - Add `try_canonicalize` and use it over `std::fs::canonicalize` (rust-lang/cargo#11866) - Fix typo (rust-lang/cargo#11944) - docs(changelog): Change wording about auto-fix message (rust-lang/cargo#11943) - Update home repo URL (rust-lang/cargo#11941) - doc(changelog): `[env]` is a table, not a stable (rust-lang/cargo#11942) - Stop using UncanonicalizedIter for QueryKind::Exact (rust-lang/cargo#11937) - Don't query permutations of the path prefix. (rust-lang/cargo#11936) - Fix typo in variable name (rust-lang/cargo#11931) - Fix Cargo warning about unused sparse configuration key (rust-lang/cargo#11930) - Switch benchsuite to the index archive. (rust-lang/cargo#11933) - Update git2 (rust-lang/cargo#11928) - Publish docs: Clarify requirements about the state of the index after publish. (rust-lang/cargo#11926) - Call out the differences between the index JSON and the API or metadata. (rust-lang/cargo#11927)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing a credential lookup, Cargo deserializes the registry configuration and detects the
registries.crates-io.protocolkey as unused and issues a warning:This fixes the issue by adding the field to the
RegistryConfigstruct.