Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cargo team charter. #12010

Merged
merged 8 commits into from
May 13, 2023
Merged

Add Cargo team charter. #12010

merged 8 commits into from
May 13, 2023

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Apr 20, 2023

This adds a document explaining what the Cargo team is and how it operates.

This is based on a document I prepared a couple years ago during the efforts to have charters for all teams. That effort has stalled, but I wanted to capture these ideas and make it clearer what is involved with being a member and how to join. The only section that is significantly new is the "Decision process" section.

In terms of detail, I wanted to strike a balance between providing the important information (the "scaffolding" so to speak), versus an exhaustive legal document. For example, this doesn't have specific requirements on what "involvement" means, team limits, term limits, specific vacation policy, accountability, consensus and conflict resolution, non-requirements (things not expected of members), specific deliverables or outcomes, measurements of "success", complete listing of the code and systems the team is responsible for, cross-team relationships, sub-team and working-group creation, roadmap management, ...etc.

For similar information, see:

@rustbot
Copy link
Collaborator

rustbot commented Apr 20, 2023

r? @weihanglo

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2023
@ehuss ehuss force-pushed the contrib-charter branch from 094784d to 33397dd Compare April 21, 2023 00:10
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very complete and informative. It is much appreciated!

src/doc/contrib/src/team.md Outdated Show resolved Hide resolved
src/doc/contrib/src/team.md Outdated Show resolved Hide resolved
src/doc/contrib/src/team.md Show resolved Hide resolved
Copy link
Contributor

@epage epage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/doc/contrib/src/team.md Outdated Show resolved Hide resolved
src/doc/contrib/src/team.md Outdated Show resolved Hide resolved
src/doc/contrib/src/team.md Outdated Show resolved Hide resolved
Members are required to always:

- Represent the Rust project in a way that upholds the [Rust code of conduct][coc] to a high standard.
- Represent the Cargo Team in a way that upholds the expectations of this charter, and be friendly, welcoming, and constructive with contributors and users.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have anything on being clear in representations that reflect the team vs the individual?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you say more about what your thoughts are here? I think I have a vague idea of what you're getting at here, but I'm not sure how to put it into words. I assume this is trying to make the distinction of making some public statement, and wanting to distinguish between "I'm speaking for the whole team" and "I'm just giving my personal viewpoint"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats it. I'm not sure what to even put down for a policy, if anything. Its just something I try to keep in mind

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would always be recognized as “Cargo team member” or whatever your strongest public image when interacting with the community. That's a thing one can never shave off even after stepping down.

For example, when one team member talks about cargo-eval pre-RFC, even when they state it's their own personal opinion. They still have a vote to affect the decision. People then tend to see it as a portion of the team's opinion if they find the connection.

That's an inevitable consequence of being a formal member.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of making a statement for the whole team, we usually start like “after the team's recent discussion, we….” I think that kind of speaking gives enough information to the audience to decide where it comes from.

Just be clear. I am fine with not having a policy here for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's absolutely the case that we'll be perceived as Cargo team members, but with some care we can make sure to state when we're speaking for the team, and when we're specifically not speaking for the team.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following today's episode of the rust drama... being unclear about whether someone was speaking on behalf of the team or just expressing their own opinion may have been a key contributor to this round of drama.

src/doc/contrib/src/team.md Outdated Show resolved Hide resolved
@ehuss ehuss force-pushed the contrib-charter branch from 33397dd to f4f4707 Compare April 22, 2023 00:08
@ehuss ehuss force-pushed the contrib-charter branch from f4f4707 to 35ed543 Compare April 22, 2023 00:22
@ehuss ehuss added the T-cargo Team: Cargo label May 1, 2023
@ehuss
Copy link
Contributor Author

ehuss commented May 1, 2023

I want to make sure there is a unanimous approval for adding this, so I'd like to make sure that this isn't merged until everyone checks off on it.

@rfcbot fcp merge

@rfcbot
Copy link
Collaborator

rfcbot commented May 1, 2023

Team member @ehuss has proposed to merge this. The next step is review by the rest of the tagged team members:

Concerns:

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period An FCP proposal has started, but not yet signed off. disposition-merge FCP with intent to merge final-comment-period FCP — a period for last comments before action is taken and removed proposed-final-comment-period An FCP proposal has started, but not yet signed off. labels May 1, 2023
@rfcbot
Copy link
Collaborator

rfcbot commented May 1, 2023

🔔 This is now entering its final comment period, as per the review above. 🔔

@joshtriplett
Copy link
Member

@rfcbot concern consensus-with-no-objections
@rfcbot concern check-with-moderation-team-on-proposed-members

@rfcbot reviewed

@rfcbot rfcbot added the proposed-final-comment-period An FCP proposal has started, but not yet signed off. label May 11, 2023
@rfcbot rfcbot removed the final-comment-period FCP — a period for last comments before action is taken label May 11, 2023
ehuss and others added 2 commits May 13, 2023 11:49
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
@ehuss
Copy link
Contributor Author

ehuss commented May 13, 2023

@joshtriplett Thank you very much for the review, I have applied your suggestions. (I don't think fcpbot allows me to resolve your concerns, but I don't think it is strictly necessary since they are just applying your suggestions.)

I'm going to go ahead and merge. Thank you everyone for the review. If you have any further questions or concerns, feel free to comment, open a new PR or issue, ask on Zulip, or direct message me.

The intent going forward is that any significant changes to this document should go through an FCP (minor clarifications, or editorial changes don't require that). This first version was intended to be a starting baseline where we can then update when we identify things that would be helpful.

@bors r+

@bors
Copy link
Contributor

bors commented May 13, 2023

📌 Commit 60a14a2 has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 13, 2023
@bors
Copy link
Contributor

bors commented May 13, 2023

⌛ Testing commit 60a14a2 with merge 31f840b...

@bors
Copy link
Contributor

bors commented May 13, 2023

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 31f840b to master...

@bors bors merged commit 31f840b into rust-lang:master May 13, 2023
@rfcbot rfcbot removed proposed-final-comment-period An FCP proposal has started, but not yet signed off. disposition-merge FCP with intent to merge labels May 13, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request May 17, 2023
Update cargo

8 commits in 13413c64ff88dd6c2824e9eb9374fc5f10895d28..09276c703a473ab33daaeb94917232e80eefd628
2023-05-10 13:46:18 +0000 to 2023-05-16 21:43:35 +0000
- docs: Clarify that crates.io doesn't link to docs.rs right away. (rust-lang/cargo#12146)
- docs(ref): Clarify MSRV is generally minor (rust-lang/cargo#12122)
- Fix `check_for_file_and_add`'s check for conflict file (rust-lang/cargo#12135)
- Fixes: Incorrect document link (rust-lang/cargo#12143)
- doc: intra-doc links and doc comments for build script (rust-lang/cargo#12133)
- Add Cargo team charter. (rust-lang/cargo#12010)
- Remove useless drop of copy type (rust-lang/cargo#12136)
- Fix dep/feat syntax with hidden implicit optional dependencies (rust-lang/cargo#12130)

r? ghost
@ehuss ehuss added this to the 1.71.0 milestone May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-cargo Team: Cargo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants