Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(embedded): Don't create an intermediate manifest #12268

Merged
merged 6 commits into from
Jun 17, 2023
Merged

fix(embedded): Don't create an intermediate manifest #12268

merged 6 commits into from
Jun 17, 2023

Commits on Jun 17, 2023

  1. refactor(embedded): Be accurate in variable name

    @epage
    epage committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    4fe39e8 View commit details
    Browse the repository at this point in the history

  2. fix(toml)!: Prevent people parsing manifests from strings

    @epage
    epage committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    fc0bb8b View commit details
    Browse the repository at this point in the history

  3. test(embedded): Verify no autobin behavior is running

    @epage
    epage committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    2c70983 View commit details
    Browse the repository at this point in the history

  4. fix(embedded): Don't create an intermediate manifest 

    To parse the manifest, we have to write it out so our regular manifest
loading code could handle it.  This updates the manifest parsing code to
handle it.

This doesn't mean this will work everywhere in all cases though.  For
example, ephemeral workspaces parses a manifest from the SourceId and
these won't have valid SourceIds.

As a consequence, `Cargo.lock` and `CARGO_TARGET_DIR` are changing from being next to
the temp manifest to being next to the script.  This still isn't the
desired behavior but stepping stones.

This also exposes the fact that we didn't disable `autobins` like the
documentation says we should.
    @epage
    epage committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    575b9ac View commit details
    Browse the repository at this point in the history

  5. fix(embedded): Ensure we don't auto-discover any targets

    @epage
    epage committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    5ed0792 View commit details
    Browse the repository at this point in the history

  6. fix(cli): Make 'cargo foo.rs' behave like --manifest-path 

    This mirrors the logic `ArgMatchesExt::root_manifest`
    @epage
    epage committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    224d2e6 View commit details
    Browse the repository at this point in the history