Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change the defaults to always check-in Cargo.lock #12382

Merged
merged 5 commits into from
Aug 21, 2023
Merged

fix: Change the defaults to always check-in Cargo.lock #12382

merged 5 commits into from
Aug 21, 2023

Commits on Jul 19, 2023

  1. docs(ci): Remove Travis example 

    When the guide was written, it only included Travis CI.  For while, it
was *the* CI service people used.  However, since git hosting services
have been integrating CI support and with Travis CI's new owners, market
share has been going down.  One estimate I found said that Travis CI's
market share is 0.94%.  If we had a compelling reason to include it,
independent of that, I would.  However, including it and making it first
in the list is a distraction.  There are CI services in more common use
(e.g. CircleCI, Jenkins) to include at this point over Travis.
    @epage
    epage committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    775f44e View commit details
    Browse the repository at this point in the history

  2. docs(ci): Add section heading to open the way for more headings

    @epage
    epage committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    b9216c1 View commit details
    Browse the repository at this point in the history

  3. docs(ci): Remove unused link

    @epage
    epage committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    eb1a257 View commit details
    Browse the repository at this point in the history

  4. docs: Generalize Cargo.lock guidance 

    Before, we were fairly prescriptive of when to check-in the `Cargo.lock`
file.   The guidance has been updated to instead explain the trade offs
and to mostly leave it in users hands.  As a starting point, we do say
to check it in for those that want an "easy answer".
    @epage
    epage committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    57aa352 View commit details
    Browse the repository at this point in the history

  5. fix(new): Don't ignore Cargo.lock for all package types 

    Following the default guidance to commit a lockfile, this updates
`cargo new` to do it by default.
    @demurgos @epage
    demurgos authored and epage committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    54ad4a0 View commit details
    Browse the repository at this point in the history