Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cargo-yank.md #12490

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Update cargo-yank.md #12490

merged 1 commit into from
Aug 14, 2023

Conversation

amosbird
Copy link
Contributor

Fix version typo in cargo-yank.md

@rustbot
Copy link
Collaborator

rustbot commented Aug 14, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @epage (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2023
weihanglo
weihanglo reviewed Aug 14, 2023
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Could you follow the CI error and regenerate the help manual?

Detected changes of man pages:
 M src/doc/src/commands/cargo-yank.md

Please run `cargo build-man` to rebuild the man pages
and commit the changes.

@amosbird
Update cargo-yank.md
0921593 
Fix version typo in cargo-yank.md
@amosbird
Copy link
Contributor Author

Sure. Done.

@amosbird amosbird force-pushed the cargo-yank-doc-fix1 branch from d1bbab4 to 0921593 Compare August 14, 2023 08:03
@rustbot rustbot added the A-cli-help Area: built-in command-line help label Aug 14, 2023
@weihanglo
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Aug 14, 2023

📌 Commit 0921593 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2023
@bors
Copy link
Contributor

bors commented Aug 14, 2023

⌛ Testing commit 0921593 with merge 0067476...

@bors
Copy link
Contributor

bors commented Aug 14, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 0067476 to master...

@bors bors merged commit 0067476 into rust-lang:master Aug 14, 2023
@weihanglo weihanglo mentioned this pull request Aug 14, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 14, 2023
@bors
Auto merge of rust-lang#114824 - weihanglo:update-cargo, r=weihanglo
3276b29 
Update cargo

6 commits in 7e9de3f4ec3708f500bec142317895b96131e47c..7c3904d6c3ed54e8a413023519b55a536ad44d5b
2023-08-13 00:47:32 +0000 to 2023-08-14 20:11:43 +0000
- fix(lints): Doctest extraction should respect `[lints]` (rust-lang/cargo#12501)
- test: relax assertions of panic message (again) (rust-lang/cargo#12500)
- doc(unstable): `cargo test` does not provide `--keep-going` (rust-lang/cargo#12492)
- fix(log): enable ansi color only in terminal (rust-lang/cargo#12488)
- Update cargo-yank.md (rust-lang/cargo#12490)
- test: bypass `rustc --test` impl details for `-Zfuture-incompat-test` (rust-lang/cargo#12491)

r? `@ghost`
@ehuss ehuss added this to the 1.73.0 milestone Aug 22, 2023
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Apr 7, 2024
@bors
Auto merge of #114824 - weihanglo:update-cargo, r=weihanglo
c29f10d 
Update cargo

6 commits in 7e9de3f4ec3708f500bec142317895b96131e47c..7c3904d6c3ed54e8a413023519b55a536ad44d5b
2023-08-13 00:47:32 +0000 to 2023-08-14 20:11:43 +0000
- fix(lints): Doctest extraction should respect `[lints]` (rust-lang/cargo#12501)
- test: relax assertions of panic message (again) (rust-lang/cargo#12500)
- doc(unstable): `cargo test` does not provide `--keep-going` (rust-lang/cargo#12492)
- fix(log): enable ansi color only in terminal (rust-lang/cargo#12488)
- Update cargo-yank.md (rust-lang/cargo#12490)
- test: bypass `rustc --test` impl details for `-Zfuture-incompat-test` (rust-lang/cargo#12491)

r? `@ghost`
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 27, 2024
@bors
Auto merge of #114824 - weihanglo:update-cargo, r=weihanglo
2d0b9f5 
Update cargo

6 commits in 7e9de3f4ec3708f500bec142317895b96131e47c..7c3904d6c3ed54e8a413023519b55a536ad44d5b
2023-08-13 00:47:32 +0000 to 2023-08-14 20:11:43 +0000
- fix(lints): Doctest extraction should respect `[lints]` (rust-lang/cargo#12501)
- test: relax assertions of panic message (again) (rust-lang/cargo#12500)
- doc(unstable): `cargo test` does not provide `--keep-going` (rust-lang/cargo#12492)
- fix(log): enable ansi color only in terminal (rust-lang/cargo#12488)
- Update cargo-yank.md (rust-lang/cargo#12490)
- test: bypass `rustc --test` impl details for `-Zfuture-incompat-test` (rust-lang/cargo#12491)

r? `@ghost`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@epage epage

Labels
A-cli-help Area: built-in command-line help A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
6 participants
@amosbird @rustbot @weihanglo @bors @ehuss @epage