Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(resolver): Make resolver behavior independent of package order #12602

Merged
merged 2 commits into from
Sep 5, 2023
Merged

fix(resolver): Make resolver behavior independent of package order #12602

merged 2 commits into from
Sep 5, 2023

Commits on Aug 30, 2023

  1. test(update): Verify extra-update behavior

    @epage
    epage committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    2676a4a View commit details
    Browse the repository at this point in the history

  2. fix(resolver): Make resolver behavior independent of package order 

    This addresses the ordering issue of for one of the problems from rust-lang#12599.

The intent behind the `path_pkg` check is to make sure we update
workspace members in the lockfile if their version number changed.
In this case, we don't need to recursively walk, because the change
doesn't affect dependencies.  However, we also shouldn't *prevent*
recursive walks which is what we are doing today, both for packages
marked to keep and for packages that have been "poisoned".  So we fix
this by moving that call after all recursive adds are complete so as to
not interfere with them.
    @epage
    epage committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    0af2f65 View commit details
    Browse the repository at this point in the history