refactor: Consolidate clap/shell styles #12655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a very rough pass at naming the styles with a focus on getting something in and keeping the colors the same.
|
r? @weihanglo (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-cli
epage
changed the title
epage
added a commit
to epage/clap-cargo
that referenced
this pull request
Sep 11, 2023
This mirrors what the API in rust-lang/cargo#12655. I'm hoping to have the `anstyle` consts be a public crate owned by the cargo team in the future after which we'll refactor to re-export it. See rust-lang/cargo#12578 for adding the style.
epage
added a commit
to epage/clap-cargo
that referenced
this pull request
Sep 11, 2023
This mirrors what the API in rust-lang/cargo#12655. I'm hoping to have the `anstyle` consts be a public crate owned by the cargo team in the future after which we'll refactor to re-export it. See rust-lang/cargo#12578 for adding the style.
weihanglo
reviewed
Sep 12, 2023
There was a problem hiding this comment.
Some texts are not applied correctly with bold style. Filed an upstream fix for that: rust-cli/anstyle#124.
Apart from that, it looks good :)
|
Updated with the new release of anstyle-termcolor |
weihanglo
approved these changes
Sep 13, 2023
|
Thanks! @bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 15, 2023
Update cargo 11 commits in 2fc85d15a542bfb610aff7682073412cf635352f..d5336f813df39d476e61fc46daabb1446350660a 2023-09-09 01:49:46 +0000 to 2023-09-14 19:55:49 +0000 - fix: emit a warning for `credential-alias` shadowing (rust-lang/cargo#12671) - refactor: fix lint errors in preparation of `[lints]` table integration (rust-lang/cargo#12669) - Limit cargo add feature print (rust-lang/cargo#12662) - Clippy (rust-lang/cargo#12667) - Prerelease candidates error message (rust-lang/cargo#12659) - Fix typos: `informations` -> `information` (rust-lang/cargo#12666) - chore: update globset to 0.4.13 (rust-lang/cargo#12665) - refactor: Consolidate clap/shell styles (rust-lang/cargo#12655) - libgit2 fixed upstream (rust-lang/cargo#12657) - Index summary enum (rust-lang/cargo#12643) - feat(help): Add styling to help output (rust-lang/cargo#12578) r? ghost
This was referenced Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This is a follow up to #12578 to reduce duplication of terminal styling.
This still leaves styling in
color_print::cstr!.This is also prep for copy/pasting into
clap-cargofor others to use. Another step might be to extractcargo::util::styleinto its own crate.How should we test and review this PR?
We have no styling tests so this can only be verified by inspection or running the commands
Additional information
I chose
anstylefor expressing these as its an API designed specifically for stable style definitions to put in public APIs.