Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(util): Prepare for splitting out semver logic #12926

Merged
merged 2 commits into from
Nov 8, 2023
Merged

refactor(util): Prepare for splitting out semver logic #12926

merged 2 commits into from
Nov 8, 2023

Commits on Nov 8, 2023

  1. refactor(util): Unify VersionExt, VersionReqExt 

    For myself, I find the trait-as-a-constructor approach of
`VersionReqExt::exact` awkward and find merging it into `VersionExt` as
`VersionExt::to_exact_req` is a bit cleaner.
For example, this would make it easier to integrate with
`PartialVersion` if we want.
    @epage
    epage committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    a1886c6 View commit details
    Browse the repository at this point in the history

  2. refactor(util): Align VersionExt, PartialVersion naming

    @epage
    epage committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    cf6d5b3 View commit details
    Browse the repository at this point in the history