Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use struct variant instead of long, commented tuple #1310

Merged
merged 1 commit into from
Feb 16, 2015

Conversation

tanadeau
Copy link
Contributor

Minor code cleanup for readability and usability for Method enum.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@tanadeau
Copy link
Contributor Author

It looks like the Travis CI Linux builds are hanging. See also #1308.

@alexcrichton
Copy link
Member

@bors: r+ 3f57587

Thanks!

@bors
Copy link
Contributor

bors commented Feb 16, 2015

⌛ Testing commit 3f57587 with merge 5fb2f33...

@bors
Copy link
Contributor

bors commented Feb 16, 2015

💔 Test failed - cargo-win-32

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Contributor

bors commented Feb 16, 2015

⌛ Testing commit 3f57587 with merge e7393a0...

bors added a commit that referenced this pull request Feb 16, 2015
Minor code cleanup for readability and usability for `Method` enum.
@bors
Copy link
Contributor

bors commented Feb 16, 2015

☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-32, cargo-win-64

@bors bors merged commit 3f57587 into rust-lang:master Feb 16, 2015
@tanadeau tanadeau deleted the use-struct-variant branch September 13, 2016 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants