Improve GitHub Actions CI config #13317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @epage (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-infrastructure
ehuss
reviewed
Jan 18, 2024
|
Regardless, let's see if it works with bors @bors try |
bors
added a commit
that referenced
this pull request
Jan 18, 2024
Improve GitHub Actions CI config This pull request improves Cargo CI by: 1. Explicitly listing the branches the main CI should be run on (to avoid running on unwanted branches, particularly in forks) 2. By adding a [concurrency](https://docs.github.com/en/actions/using-jobs/using-concurrency) config so that only one "CI" runs for each "group" (one by PR), very inspired by rust-lang/rust [one](https://github.com/rust-lang/rust/blob/c485ee71477a29041895c47cc441b364670f3772/.github/workflows/ci.yml#L35) 3. By making all the jobs run only if triggered from this repository (to avoid having forks unnecessarily run CI jobs) 4. By making all the checkouts take `fetch-depth: 2` like done in [rust-lang/rust](https://github.com/rust-lang/rust/blob/c485ee71477a29041895c47cc441b364670f3772/.github/workflows/ci.yml#L452-L455) (to avoid unnecessary work, saves bandwidth and maybe a bit of time) The main motivation for this PR was (at first) to make the CI jobs not run on forks since it's a waste of CI resources as well as always failing (like [this](https://github.com/Urgau/cargo/actions/runs/7567435677/job/20606586124)); but after looking at the `main.yml` config I took the opportunity to improve the situation by using rust-lang/rust [ci.yml](https://github.com/rust-lang/rust/blob/master/.github/workflows/ci.yml) as reference.
Urgau
force-pushed
the
improve-ci
branch
2 times, most recently
from
c60488f to
e30dac4
Compare
|
Hum, I have been informed by @weihanglo that apparently I believe this is due to an overly constrained condition in the |
|
Sure. Do it again. @bors try |
bors
added a commit
that referenced
this pull request
Jan 18, 2024
Improve GitHub Actions CI config This pull request improves Cargo CI by: 1. Explicitly listing the branches the main CI should be run on (to avoid running on unwanted branches, particularly in forks) 2. By adding a [concurrency](https://docs.github.com/en/actions/using-jobs/using-concurrency) config so that only one "CI" runs for each "group" (one by PR), very inspired by rust-lang/rust [one](https://github.com/rust-lang/rust/blob/c485ee71477a29041895c47cc441b364670f3772/.github/workflows/ci.yml#L35) 3. ~~By making all the jobs run only if triggered from this repository (to avoid having forks unnecessarily run CI jobs)~~ 4. ~~By making all the checkouts take `fetch-depth: 2` like done in [rust-lang/rust](https://github.com/rust-lang/rust/blob/c485ee71477a29041895c47cc441b364670f3772/.github/workflows/ci.yml#L452-L455) (to avoid unnecessary work, saves bandwidth and maybe a bit of time)~~ The main motivation for this PR was (at first) to make the CI jobs not run on forks since it's a waste of CI resources as well as always failing (like [this](https://github.com/Urgau/cargo/actions/runs/7567435677/job/20606586124)); but after looking at the `main.yml` config I took the opportunity to improve the situation by using rust-lang/rust [ci.yml](https://github.com/rust-lang/rust/blob/master/.github/workflows/ci.yml) as reference.
|
☀️ Try build successful - checks-actions |
1 similar comment
|
☀️ Try build successful - checks-actions |
|
Looks like everything is good? @bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 24, 2024
Update cargo 10 commits in 1ae631085f01c1a72d05df1ec81f3759a8360042..7bb7b539558dc88bea44cee4168b6269bf8177b0 2024-01-17 17:26:41 +0000 to 2024-01-20 00:15:32 +0000 - feat: inherit jobserver from env for all kinds of runner (rust-lang/cargo#12776) - Fix static_mut_ref warning. (rust-lang/cargo#13329) - fix(trim-paths): remap common prefix only (rust-lang/cargo#13210) - fix(cargo-rustdoc): use same path by output format logic everywhere (rust-lang/cargo#13325) - chore: Make MSRV=N-2 the workspace default (rust-lang/cargo#13324) - Fix precise-prerelease tracking link. (rust-lang/cargo#13320) - test(pkgid): keep package ID format in sync (rust-lang/cargo#13322) - Improve GitHub Actions CI config (rust-lang/cargo#13317) - Go back to passing an empty `values()` when no features are declared (rust-lang/cargo#13316) - fix(`--package`): accept `?` if it's a valid pkgid spec (rust-lang/cargo#13315) r? ghost
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 24, 2024
Update cargo 10 commits in 1ae631085f01c1a72d05df1ec81f3759a8360042..7bb7b539558dc88bea44cee4168b6269bf8177b0 2024-01-17 17:26:41 +0000 to 2024-01-20 00:15:32 +0000 - feat: inherit jobserver from env for all kinds of runner (rust-lang/cargo#12776) - Fix static_mut_ref warning. (rust-lang/cargo#13329) - fix(trim-paths): remap common prefix only (rust-lang/cargo#13210) - fix(cargo-rustdoc): use same path by output format logic everywhere (rust-lang/cargo#13325) - chore: Make MSRV=N-2 the workspace default (rust-lang/cargo#13324) - Fix precise-prerelease tracking link. (rust-lang/cargo#13320) - test(pkgid): keep package ID format in sync (rust-lang/cargo#13322) - Improve GitHub Actions CI config (rust-lang/cargo#13317) - Go back to passing an empty `values()` when no features are declared (rust-lang/cargo#13316) - fix(`--package`): accept `?` if it's a valid pkgid spec (rust-lang/cargo#13315) r? ghost
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 24, 2024
Update cargo 10 commits in 1ae631085f01c1a72d05df1ec81f3759a8360042..7bb7b539558dc88bea44cee4168b6269bf8177b0 2024-01-17 17:26:41 +0000 to 2024-01-20 00:15:32 +0000 - feat: inherit jobserver from env for all kinds of runner (rust-lang/cargo#12776) - Fix static_mut_ref warning. (rust-lang/cargo#13329) - fix(trim-paths): remap common prefix only (rust-lang/cargo#13210) - fix(cargo-rustdoc): use same path by output format logic everywhere (rust-lang/cargo#13325) - chore: Make MSRV=N-2 the workspace default (rust-lang/cargo#13324) - Fix precise-prerelease tracking link. (rust-lang/cargo#13320) - test(pkgid): keep package ID format in sync (rust-lang/cargo#13322) - Improve GitHub Actions CI config (rust-lang/cargo#13317) - Go back to passing an empty `values()` when no features are declared (rust-lang/cargo#13316) - fix(`--package`): accept `?` if it's a valid pkgid spec (rust-lang/cargo#13315) r? ghost
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 24, 2024
Update cargo 10 commits in 1ae631085f01c1a72d05df1ec81f3759a8360042..7bb7b539558dc88bea44cee4168b6269bf8177b0 2024-01-17 17:26:41 +0000 to 2024-01-20 00:15:32 +0000 - feat: inherit jobserver from env for all kinds of runner (rust-lang/cargo#12776) - Fix static_mut_ref warning. (rust-lang/cargo#13329) - fix(trim-paths): remap common prefix only (rust-lang/cargo#13210) - fix(cargo-rustdoc): use same path by output format logic everywhere (rust-lang/cargo#13325) - chore: Make MSRV=N-2 the workspace default (rust-lang/cargo#13324) - Fix precise-prerelease tracking link. (rust-lang/cargo#13320) - test(pkgid): keep package ID format in sync (rust-lang/cargo#13322) - Improve GitHub Actions CI config (rust-lang/cargo#13317) - Go back to passing an empty `values()` when no features are declared (rust-lang/cargo#13316) - fix(`--package`): accept `?` if it's a valid pkgid spec (rust-lang/cargo#13315) r? ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves Cargo CI by:
By making all the jobs run only if triggered from this repository (to avoid having forks unnecessarily run CI jobs)By making all the checkouts takefetch-depth: 2like done in rust-lang/rust (to avoid unnecessary work, saves bandwidth and maybe a bit of time)refs/heads/tryin thesuccessandfailurebors job gates (to fixbors tryfrom timing out)The main motivation for this PR was (at first) to make the CI jobs not run on forks since it's a waste of CI resources as well as always failing (like this); but after looking at the
main.ymlconfig I took the opportunity to improve the situation by using rust-lang/rust ci.yml as reference.