rustup #1336
rustup #1336
Conversation
|
Depends on ujh/hamcrest-rust#15 |
ghost
mentioned this pull request
|
This should be good to go, I think? |
| #![cfg_attr(test, deny(warnings))] | ||
| #![feature(collections, hash, libc, os, std_misc, unicode, env, core)] | ||
| #![feature(old_io, old_path, str_words)] | ||
| //#![cfg_attr(test, deny(warnings))] |
There was a problem hiding this comment.
There are deprecation warnings with CString::from_{vec,slice} that are not easily fixable and would need quite a lot of work currently and I reckon that would be easier with the new io/path/os/fs in place.
There was a problem hiding this comment.
And just tried with alpha.2 which also fails because the unstable features create a warning making the test build fail.
|
Looks like the |
|
Incidentally, it would be great if this patch could compile with alpha.2 (as written |
globin
force-pushed
the
rustup
branch
3 times, most recently
from
cffd7f2
to
253548d
Compare
|
Updated, have I introduced the failing tests? |
|
There are still some travis failures (cross builds and such). I think the installation format has changed and the hokey merge-the-repos behavior we had before isn't quite so valid any more. I also don't mind taking this over to help push it through. |
|
Thanks for taking over 👍 |
This temporarily allows warnings for test to keep calls to
CString::from_{vec,slice}for now as this creates an enormous fallout which is probably mitigated partly by a switch to the new io, fs, path libraries as far as I can see.