doc: Hide cargo-fetch description in offline man page
#13364
Conversation
rustbot
added
A-cli
src/doc/man/cargo-fetch.md
Outdated
| @@ -2,6 +2,7 @@ | |||
| {{~*set command="fetch"}} | |||
There was a problem hiding this comment.
For each command there should be a command variable available, so guess we can check if it is fetch and exclude the self-referential part.
Some place not set command, like cargo-vendor.md, cargo-verify-project.md.
src/bin/cargo/commands/fetch.rs
Outdated
| @@ -9,6 +9,7 @@ pub fn cli() -> Command { | |||
| .arg_silent_suggestion() | |||
| .arg_target_triple("Fetch dependencies for the target triple") | |||
| .arg_manifest_path() | |||
| .arg(flag("offline", "Run without accessing the network").hide(true)) | |||
There was a problem hiding this comment.
This could be used to test if all packages are fetched. Unsure if its worth showing for that reason or not.
If we hide it, should we also have the command say its deprecated when used?
There was a problem hiding this comment.
I think I'm solving the wrong problem, although my first impression is that this option is really not used.
| network and the network is not available. With this flag, Cargo will | ||
| attempt to proceed without the network if possible. | ||
|
|
||
| Beware that this may result in different dependency resolution than |
There was a problem hiding this comment.
Beware that this may result in different dependency resolution than
Comment online mode
Haven't tested it. If this statement is true, we may want to keep this, as it makes a huge difference between with and without --offline.
There was a problem hiding this comment.
See the cargo-fetch(1)
command to download dependencies before going offline.
I may have taken too big a step, and the original problem may have just been to remove this
linyihai
force-pushed
the
fetch-remove-offline
branch
from
b745dbb
to
2e0c1ac
Compare
linyihai
changed the title
offline flag for cargo-fetchcargo-fetch description in offline man page
linyihai
force-pushed
the
fetch-remove-offline
branch
from
2e0c1ac
to
333e8da
Compare
| @@ -18,8 +18,10 @@ proceed without the network if possible. | |||
| Beware that this may result in different dependency resolution than online | |||
| mode. Cargo will restrict itself to crates that are downloaded locally, even | |||
| if there might be a newer version as indicated in the local copy of the index. | |||
| {{#if (ne no-fetch-in-offline true)}} | |||
There was a problem hiding this comment.
Would this work?
| {{#if (ne no-fetch-in-offline true)}} | |
| {{#if (ne command "fetch")}} |
There was a problem hiding this comment.
Yes, it works. I should have tried this before, but it didn't work.
linyihai
force-pushed
the
fetch-remove-offline
branch
from
333e8da
to
c028c72
Compare
|
Thanks! @bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
|
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
Update cargo 24 commits in 7bb7b539558dc88bea44cee4168b6269bf8177b0..cdf84b69d0416c57ac9dc3459af80dfb4883d27a 2024-01-20 00:15:32 +0000 to 2024-02-02 19:39:16 +0000 - Apply `-Zpanic-abort-tests` to doctests too (rust-lang/cargo#13388) - Don't print rustdoc command lines on failure by default (rust-lang/cargo#13387) - Ensure `nonzero_exit_code` test isn't affected by developers `RUST_BACKTRACE` setting (rust-lang/cargo#13385) - Add `docsrs` cfg as a well known `--check-cfg` (rust-lang/cargo#13383) - fix(new): Print a note, rather than a comment, for more information (rust-lang/cargo#13371) - Change tests to support changes to suggestion (rust-lang/cargo#13382) - chore(ci): enable m1 runner (rust-lang/cargo#13377) - fix(toml): Improve map/sequence error message (rust-lang/cargo#13376) - fix(diagnostic): Don't panic on empty spans (rust-lang/cargo#13375) - doc: Hide `cargo-fetch` description in offline man page (rust-lang/cargo#13364) - feat: stabilize lockfile v4 (rust-lang/cargo#12852) - fix(new): Print a 'Creating', rather than 'Created' status (rust-lang/cargo#13367) - fix: use spec id instead of name to match package (rust-lang/cargo#13335) - refactor(shell): Use new fancy anstyle API (rust-lang/cargo#13368) - feat(cargo-update): `--precise` to allow yanked versions (rust-lang/cargo#13333) - refactor: remove unnecessary Option in `Freshness::Dirty` (rust-lang/cargo#13361) - doc: Replace version with `latest` for jobserver link (rust-lang/cargo#13366) - test: data layout fix for `x86_64-unknown-none-gnu` (rust-lang/cargo#13362) - docs(ref): Try to improve reg auth docs (rust-lang/cargo#13351) - fix typo of rustbuild, instead of rustuild (rust-lang/cargo#13357) - fix(config): Deprecate non-extension files (rust-lang/cargo#13349) - fix(cli): Improve errors related to cargo script (rust-lang/cargo#13346) - fix list option description starting with uppercase (rust-lang/cargo#13344) - Fix typo in test (rust-lang/cargo#13342)
What does this PR try to resolve?
Fixes #13232
How should we test and review this PR?
Suggest review commit by commit.
Additional information
r? @weihanglo