Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use i32 rather than usize as "default integer" in library template #13939

Merged
merged 1 commit into from
May 22, 2024
Merged

Use i32 rather than usize as "default integer" in library template #13939

merged 1 commit into from
May 22, 2024

Conversation

tbu-
Copy link
Contributor

@tbu- tbu- commented May 20, 2024

usize was renamed from uint in order to convey that it's not the "default integer type". Guide new users to use i32 instead of usize.

@rustbot
Copy link
Collaborator

rustbot commented May 20, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added Command-new S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2024
@tbu- tbu- force-pushed the pr_template_no_usize branch from cb0e1b8 to 8ad3510 Compare May 20, 2024 22:33
weihanglo
weihanglo reviewed May 22, 2024
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable. I am more curious on how you found this and why you think knowing the default integer type is important for new Rust users. Mind sharing a bit?

@tbu-
Copy link
Contributor Author

tbu- commented May 22, 2024

I am more curious on how you found this and why you think knowing the default integer type is important for new Rust users.

I found this by creating a new library with Cargo and seeing that the example code was unnecessarily using usize.

I wouldn't exactly say it's important to new Rust users, but I wouldn't set a bad example by using usize when a more concrete integer type would be reasonable.

@ChrisDenton
Copy link
Member

I think u64 might be better from a teaching standpoint.

64-bits is large enough to hold most numbers you use in programming. Larger sizes (e.g. 128 or 256) have more niche use cases and smaller sizes are mostly an optimization (or for fitting an external specification). There's little reason to needlessly risk overflow.

I think unsigned is better because many languages don't have a separate type for signed and unsigned. So it serves to teach you about them with a nice error message if you try to use a negative.

@tbu-
Copy link
Contributor Author

tbu- commented May 22, 2024

I think u64 might be better from a teaching standpoint.

I don't particularly care about the exact integer type used here, i32, i64, u32, u64 would all work here, in my opinion. Does anyone else have an opinion on this or should I just change it to u64?

@weihanglo
Copy link
Member

Agree with Chris that u64 sounds better. Some common programming tasks like calculating file size is better off with u64.

BTW, the template was added in #10706, and somebody also needs to update the book like rust-lang/book#3533 after merge.

@tbu-
Use u64 rather than usize as "default integer" in library template
a29742a 
`usize` was renamed from `uint` in order to convey that it's not the
"default integer type". Guide new users to use integers with specific
bit width instead of `usize`.
@tbu- tbu- force-pushed the pr_template_no_usize branch from 8ad3510 to a29742a Compare May 22, 2024 14:13
@tbu-
Copy link
Contributor Author

tbu- commented May 22, 2024

I think u64 might be better from a teaching standpoint.

Changed to u64.

tbu- added a commit to tbu-/rust-book that referenced this pull request May 22, 2024
@tbu-
Update listings to account for cargo new template update
3367ff4 
Requires rust-lang/cargo#13939.
@tbu- tbu- mentioned this pull request May 22, 2024
Merged
@weihanglo
Copy link
Member

The template cargo new creates doesn't really have stability guarantee so I am happy to just merge this. If there turns out to be an issue, please call it out and we can consider reverting.

@bors r+

@bors
Copy link
Contributor

bors commented May 22, 2024

📌 Commit a29742a has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2024
@bors
Copy link
Contributor

bors commented May 22, 2024

⌛ Testing commit a29742a with merge 048e804...

@bors
Copy link
Contributor

bors commented May 22, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 048e804 to master...

@bors bors merged commit 048e804 into rust-lang:master May 22, 2024
21 checks passed
@weihanglo weihanglo mentioned this pull request May 24, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 24, 2024
@bors
Auto merge of rust-lang#125524 - weihanglo:update-cargo, r=weihanglo
6545656 
Update cargo

7 commits in 84dc5dc11a9007a08f27170454da6097265e510e..a8d72c675ee52dd57f0d8f2bae6655913c15b2fb
2024-05-20 18:57:08 +0000 to 2024-05-24 03:34:17 +0000
- Improve error description when deserializing partial field struct (rust-lang/cargo#13956)
- fix: remove symlink dir on Windows (rust-lang/cargo#13910)
- Fix wrong type of rustc-flags in documentation (rust-lang/cargo#13957)
- Add more high level traces (rust-lang/cargo#13951)
- upgrade gix from 0.62 to 0.63 (rust-lang/cargo#13948)
- Use `i32` rather than `usize` as "default integer" in library template (rust-lang/cargo#13939)
- fetch specific commits even if the github fast path fails (rust-lang/cargo#13946)

r? ghost
bors added a commit to rust-lang-ci/rust that referenced this pull request May 25, 2024
@bors
Auto merge of rust-lang#125524 - weihanglo:update-cargo, r=weihanglo
3a225b5 
Update cargo

7 commits in 84dc5dc11a9007a08f27170454da6097265e510e..a8d72c675ee52dd57f0d8f2bae6655913c15b2fb
2024-05-20 18:57:08 +0000 to 2024-05-24 03:34:17 +0000
- Improve error description when deserializing partial field struct (rust-lang/cargo#13956)
- fix: remove symlink dir on Windows (rust-lang/cargo#13910)
- Fix wrong type of rustc-flags in documentation (rust-lang/cargo#13957)
- Add more high level traces (rust-lang/cargo#13951)
- upgrade gix from 0.62 to 0.63 (rust-lang/cargo#13948)
- Use `i32` rather than `usize` as "default integer" in library template (rust-lang/cargo#13939)
- fetch specific commits even if the github fast path fails (rust-lang/cargo#13946)

r? ghost
bors added a commit to rust-lang-ci/rust that referenced this pull request May 25, 2024
@bors
Auto merge of rust-lang#125524 - weihanglo:update-cargo, r=weihanglo
a614dce 
Update cargo

7 commits in 84dc5dc11a9007a08f27170454da6097265e510e..a8d72c675ee52dd57f0d8f2bae6655913c15b2fb
2024-05-20 18:57:08 +0000 to 2024-05-24 03:34:17 +0000
- Improve error description when deserializing partial field struct (rust-lang/cargo#13956)
- fix: remove symlink dir on Windows (rust-lang/cargo#13910)
- Fix wrong type of rustc-flags in documentation (rust-lang/cargo#13957)
- Add more high level traces (rust-lang/cargo#13951)
- upgrade gix from 0.62 to 0.63 (rust-lang/cargo#13948)
- Use `i32` rather than `usize` as "default integer" in library template (rust-lang/cargo#13939)
- fetch specific commits even if the github fast path fails (rust-lang/cargo#13946)

r? ghost
bors added a commit to rust-lang-ci/rust that referenced this pull request May 25, 2024
@bors
Auto merge of rust-lang#125524 - weihanglo:update-cargo, r=weihanglo
77d4115 
Update cargo

7 commits in 84dc5dc11a9007a08f27170454da6097265e510e..a8d72c675ee52dd57f0d8f2bae6655913c15b2fb
2024-05-20 18:57:08 +0000 to 2024-05-24 03:34:17 +0000
- Improve error description when deserializing partial field struct (rust-lang/cargo#13956)
- fix: remove symlink dir on Windows (rust-lang/cargo#13910)
- Fix wrong type of rustc-flags in documentation (rust-lang/cargo#13957)
- Add more high level traces (rust-lang/cargo#13951)
- upgrade gix from 0.62 to 0.63 (rust-lang/cargo#13948)
- Use `i32` rather than `usize` as "default integer" in library template (rust-lang/cargo#13939)
- fetch specific commits even if the github fast path fails (rust-lang/cargo#13946)

r? ghost
@rustbot rustbot added this to the 1.80.0 milestone May 25, 2024
RalfJung pushed a commit to RalfJung/miri that referenced this pull request May 27, 2024
@bors
Auto merge of #125524 - weihanglo:update-cargo, r=weihanglo
a5e1f3e 
Update cargo

7 commits in 84dc5dc11a9007a08f27170454da6097265e510e..a8d72c675ee52dd57f0d8f2bae6655913c15b2fb
2024-05-20 18:57:08 +0000 to 2024-05-24 03:34:17 +0000
- Improve error description when deserializing partial field struct (rust-lang/cargo#13956)
- fix: remove symlink dir on Windows (rust-lang/cargo#13910)
- Fix wrong type of rustc-flags in documentation (rust-lang/cargo#13957)
- Add more high level traces (rust-lang/cargo#13951)
- upgrade gix from 0.62 to 0.63 (rust-lang/cargo#13948)
- Use `i32` rather than `usize` as "default integer" in library template (rust-lang/cargo#13939)
- fetch specific commits even if the github fast path fails (rust-lang/cargo#13946)

r? ghost
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Jun 28, 2024
@bors
Auto merge of #125524 - weihanglo:update-cargo, r=weihanglo
0403219 
Update cargo

7 commits in 84dc5dc11a9007a08f27170454da6097265e510e..a8d72c675ee52dd57f0d8f2bae6655913c15b2fb
2024-05-20 18:57:08 +0000 to 2024-05-24 03:34:17 +0000
- Improve error description when deserializing partial field struct (rust-lang/cargo#13956)
- fix: remove symlink dir on Windows (rust-lang/cargo#13910)
- Fix wrong type of rustc-flags in documentation (rust-lang/cargo#13957)
- Add more high level traces (rust-lang/cargo#13951)
- upgrade gix from 0.62 to 0.63 (rust-lang/cargo#13948)
- Use `i32` rather than `usize` as "default integer" in library template (rust-lang/cargo#13939)
- fetch specific commits even if the github fast path fails (rust-lang/cargo#13946)

r? ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@epage epage

Labels
Command-new S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.
6 participants
@tbu- @rustbot @ChrisDenton @weihanglo @bors @epage