Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): Ensure --config net.git-fetch-with-cli=true is respected #13992

Merged
merged 2 commits into from
May 31, 2024
Merged

fix(config): Ensure --config net.git-fetch-with-cli=true is respected #13992

merged 2 commits into from
May 31, 2024

Commits on May 31, 2024

  1. test(config): Show current git-fetch-with-cli behavior

    @epage
    epage committed May 31, 2024
    Configuration menu
    Copy the full SHA
    c0a7957 View commit details
    Browse the repository at this point in the history

  2. Revert "fix(context): Configure Shell before emitting messages" 

    This reverts commit f525e1f.

This removes color control from warnings for unstable features.
For some reason this removed color support from `cargo -Zhelp` in the
tests but I can't reproduce it locally.

The most important thing was getting the config fix in.
There are two follow ups
- Can we have the config working *and* color?
- Why did this fail for this field and not the others we already had
  tests for?

I ran out my immediate time box for looking into these.

Fixes rust-lang#13991
    @epage
    epage committed May 31, 2024
    Configuration menu
    Copy the full SHA
    4ce2b61 View commit details
    Browse the repository at this point in the history