Cargo Tree: New format string parameter #14008
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new format parameter to allow querying what platform each dependency is built for.
What does this PR try to resolve?
rules_rust is using
cargo tree
to query the dependency graph and create an equivalent internal graph of dependencies per architecture it's configured to build for. The issue I observed with their current implementation is that they were querying all build dependencies when querying for each target architecture, which caused host architecture only transitive build deps to be added to graph of the target architecture.I tried querying with just
build
edges, but then we don't get to see thenormal
transitive deps under thebuild
deps so we can't actually build a dependency graph of all the build deps accurately using filtering. Next I went to look through the format parameters and saw there wasn't really a way for me to extract what platform it's building for, hence this PR.