Don't specify the depedency name in the cargo add inferred name test
#14357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @epage (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
the
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 5, 2024
Don't specify the depedency name in the `cargo add` inferred name test The `cargo_add/path_inferred_name` was incorrectly adding the name of the dependency to add in its command line.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
This comment was marked as outdated.
This comment was marked as outdated.
|
See #14353 (comment) |
|
@rustbot ready |
|
@bors retry |
bors
added
S-waiting-on-bors
|
@bors r=epage |
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 7, 2024
Update cargo 3 commits in fa646583675d7c140482bd906145c71b7fb4fc2b..94977cb1fab003d45eb5bb108cb5e2fa0149672a 2024-08-02 16:08:06 +0000 to 2024-08-06 21:42:10 +0000 - Don't specify the depedency name in the `cargo add` inferred name test (rust-lang/cargo#14357) - Fix renamed disallowed cfg lint name (rust-lang/cargo#14352) - fix(build-std): remove hack on creating virtual std workspace (rust-lang/cargo#14358) r? ghost
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Aug 12, 2024
Update cargo 3 commits in fa646583675d7c140482bd906145c71b7fb4fc2b..94977cb1fab003d45eb5bb108cb5e2fa0149672a 2024-08-02 16:08:06 +0000 to 2024-08-06 21:42:10 +0000 - Don't specify the depedency name in the `cargo add` inferred name test (rust-lang/cargo#14357) - Fix renamed disallowed cfg lint name (rust-lang/cargo#14352) - fix(build-std): remove hack on creating virtual std workspace (rust-lang/cargo#14358) r? ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cargo_add/path_inferred_namewas incorrectly adding the name of the dependency to add in its command line.