Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vendor): Strip excluded build targets #14367

Merged
merged 5 commits into from
Aug 7, 2024
Merged

fix(vendor): Strip excluded build targets #14367

merged 5 commits into from
Aug 7, 2024

Commits on Aug 7, 2024

  1. test(vendor): Clarify what vendor config is used

    @epage
    epage committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    f8dd12b View commit details
    Browse the repository at this point in the history

  2. test(vendor): Fork the package tests

    @epage
    epage committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    700dfeb View commit details
    Browse the repository at this point in the history

  3. test(vendor): Drop explicitlu specified build-target cases 

    Since we already cover this for `cargo package` and we turn all
implicit targets into explicit targets (making implicit tests cover
explicit cases), this becomes redundant.
    @epage
    epage committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    26d654f View commit details
    Browse the repository at this point in the history

  4. test(vendor): Port 'package' tests to 'vendor'

    @epage
    epage committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    33862df View commit details
    Browse the repository at this point in the history

  5. fix(vendor): Strip excluded build targets 

    This is a **very** hacky solution, duplicating the minimum of what
`prepare_for_publish` does to fix this one issue and in the least
intrusive way to the vendor code.

The intention is to keep this low risk for backporting to beta and
stable.
We need to revisit this, refactoring the `cargo package` code so that we
can call into that for each vendored dependency.

Fixes rust-lang#14348
    @epage
    epage committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    1ae77f5 View commit details
    Browse the repository at this point in the history