Don't use flock on NFS mounts #2623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Completely skip file locking when we detect an NFS mount via `statfs`. Closes rust-lang#2615
|
r? @brson |
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
| let mut buf: libc::statfs = mem::zeroed(); | ||
| let r = libc::statfs(path.as_ptr(), &mut buf); | ||
|
|
||
| r == 0 && buf.f_type == libc::NFS_SUPER_MAGIC |
There was a problem hiding this comment.
After googling this I'm even more curious. Just magic stuff.
|
@bors r+ |
|
📌 Commit b0ecb90 has been approved by |
bors
added a commit
that referenced
this pull request
Apr 29, 2016
Don't use flock on NFS mounts Completely skip file locking when we detect an NFS mount via `statfs`. Closes #2615
|
Do you know what happens when using NFS on other Oses? |
|
I have no idea :( |
|
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
|
Here is an examples of lock file error on an nfs file system on OS X. |
|
@Kerosene2000 thanks for the report! I'll send a PR soon |
|
(PR is #2720) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely skip file locking when we detect an NFS mount via
statfs.Closes #2615