Switch to output release/debug after compile #2909
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Image to see a better example:
|
|
I feel like "Finished" should be the same color as "Compiling" (and aligned to it) |
| @@ -76,7 +78,7 @@ impl<'a> JobState<'a> { | |||
| } | |||
|
|
|||
| impl<'a> JobQueue<'a> { | |||
| pub fn new<'cfg>(cx: &Context<'a, 'cfg>) -> JobQueue<'a> { | |||
| pub fn new<'cfg>(cx: &Context<'a, 'cfg>, is_release: bool, is_doc_all: bool) -> JobQueue<'a> { | |||
There was a problem hiding this comment.
I think these booleans are actually accessible through cx.build_config, so perhaps they don't need to be passed in?
|
I personally like this being set apart a bit so you know it's not just another crate being compiled, but I could go both ways. |
|
I can go either way re: styling. Shouldn't be too hard to fix up the tests now that they're updated. |
sophiajt
force-pushed
the
debug_release_at_bottom
branch
from
c26c14a
to
60bc9d4
Compare
|
Now:
|
|
Looks good to me, thanks @jonathandturner! Could you also squash the commits down? |
sophiajt
force-pushed
the
debug_release_at_bottom
branch
from
99229a3
to
cd955f1
Compare
|
Thanks @jonathandturner! |
…crichton Switch to output release/debug after compile This is similar to #2896 but instead of inline, it puts an indicator at the bottom showing if it was a release or debug build. ``` jturner-23759:cargo jturner$ ./target/release/cargo build Finished debug (unoptimized + debuginfo) build. jturner-23759:cargo jturner$ ./target/release/cargo build --release Finished release (optimized) build. ```
|
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
This is similar to #2896 but instead of inline, it puts an indicator at the bottom showing if it was a release or debug build.