Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transitive doctests panic=abort #3021

Merged
merged 1 commit into from
Aug 23, 2016

Conversation

alexcrichton
Copy link
Member

Ensure that when we compile doctested libraries or examples we use the same
panic mode as the rest of the tests, namely ignoring panic=abort b/c libtest
isn't compiled with panic=abort.

Closes #3017

Ensure that when we compile doctested libraries or examples we use the same
panic mode as the rest of the tests, namely ignoring panic=abort b/c libtest
isn't compiled with panic=abort.

Closes rust-lang#3017
@rust-highfive
Copy link

@alexcrichton: no appropriate reviewer found, use r? to override

@alexcrichton
Copy link
Member Author

r? @brson

@brson
Copy link
Contributor

brson commented Aug 23, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Aug 23, 2016

📌 Commit 23498ec has been approved by brson

@bors
Copy link
Contributor

bors commented Aug 23, 2016

⌛ Testing commit 23498ec with merge 628d790...

bors added a commit that referenced this pull request Aug 23, 2016
Fix transitive doctests panic=abort

Ensure that when we compile doctested libraries or examples we use the same
panic mode as the rest of the tests, namely ignoring panic=abort b/c libtest
isn't compiled with panic=abort.

Closes #3017
@bors
Copy link
Contributor

bors commented Aug 23, 2016

💔 Test failed - cargo-win-gnu-64

@alexcrichton
Copy link
Member Author

@bors: retry

On Tue, Aug 23, 2016 at 1:57 PM, bors notifications@github.com wrote:

💔 Test failed - cargo-win-gnu-64
https://buildbot.rust-lang.org/builders/cargo-win-gnu-64/builds/679


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3021 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95FF6nmYKo4z5Jq2DwFIfemb1UTwtks5qi17MgaJpZM4Jo085
.

@bors
Copy link
Contributor

bors commented Aug 23, 2016

⌛ Testing commit 23498ec with merge 3fe50e1...

bors added a commit that referenced this pull request Aug 23, 2016
Fix transitive doctests panic=abort

Ensure that when we compile doctested libraries or examples we use the same
panic mode as the rest of the tests, namely ignoring panic=abort b/c libtest
isn't compiled with panic=abort.

Closes #3017
@bors
Copy link
Contributor

bors commented Aug 23, 2016

☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64
Approved by: brson
Pushing 3fe50e1 to master...

@bors bors merged commit 23498ec into rust-lang:master Aug 23, 2016
@alexcrichton alexcrichton deleted the test-release-panic-abort branch September 6, 2016 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants