Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix POSIX shell in configure script (support Illumos & Solaris) #3050

Merged
merged 1 commit into from
Aug 28, 2016

Conversation

nbaksalyar
Copy link
Contributor

This patch provides the same fix that is applied for the configure script in rustc:
https://github.com/rust-lang/rust/blob/master/configure#L3-L9. It is required because #!/bin/sh is not Bash/POSIX-compatible on Solaris and its derivatives by default.

This change was previously discussed there: rust-lang/rust#28589.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Aug 28, 2016

📌 Commit 1e38c58 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Aug 28, 2016

⌛ Testing commit 1e38c58 with merge c7ffb3e...

bors added a commit that referenced this pull request Aug 28, 2016
Fix POSIX shell in configure script (support Illumos & Solaris)

This patch provides the same fix that is applied for the `configure` script in rustc:
https://github.com/rust-lang/rust/blob/master/configure#L3-L9. It is required because `#!/bin/sh` is not Bash/POSIX-compatible on Solaris and its derivatives by default.

This change was previously discussed there: rust-lang/rust#28589.
@bors
Copy link
Contributor

bors commented Aug 28, 2016

☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64
Approved by: alexcrichton
Pushing c7ffb3e to master...

@bors bors merged commit 1e38c58 into rust-lang:master Aug 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants