Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test requested --target from source of truth #3145

Merged
merged 1 commit into from
Oct 6, 2016

Conversation

alexcrichton
Copy link
Member

We skip doc tests for any cross compiles (as they don't work) but to detect a
cross compile we checked --target but forgot to check other locations like
CARGO_BUILD_TARGET or [build.target]. This alters the check to ensure that
it verifies from the source of truth whether a cross compilation happened or
not.

Closes #3143

We skip doc tests for any cross compiles (as they don't work) but to detect a
cross compile we checked `--target` but forgot to check other locations like
`CARGO_BUILD_TARGET` or `[build.target]`. This alters the check to ensure that
it verifies from the source of truth whether a cross compilation happened or
not.

Closes rust-lang#3143
@rust-highfive
Copy link

@alexcrichton: no appropriate reviewer found, use r? to override

@alexcrichton
Copy link
Member Author

r? @brson

@brson
Copy link
Contributor

brson commented Oct 5, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Oct 5, 2016

📌 Commit 9f1203f has been approved by brson

@bors
Copy link
Contributor

bors commented Oct 6, 2016

⌛ Testing commit 9f1203f with merge 885dc89...

bors added a commit that referenced this pull request Oct 6, 2016
Test requested --target from source of truth

We skip doc tests for any cross compiles (as they don't work) but to detect a
cross compile we checked `--target` but forgot to check other locations like
`CARGO_BUILD_TARGET` or `[build.target]`. This alters the check to ensure that
it verifies from the source of truth whether a cross compilation happened or
not.

Closes #3143
@bors
Copy link
Contributor

bors commented Oct 6, 2016

☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64
Approved by: brson
Pushing 885dc89 to master...

@bors bors merged commit 9f1203f into rust-lang:master Oct 6, 2016
@alexcrichton alexcrichton deleted the rustdoc-cross-test branch October 6, 2016 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants