Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a [/] macro expansion for tests #3257

Merged
merged 5 commits into from
Nov 7, 2016
Merged

Conversation

nipunn1313
Copy link
Contributor

Converts to backslash on windows. Currently, we're using [..],
so this will tighten up the tests.

Converts to backslash on windows. Currently, we're using [..],
so this will tighten up the tests.
@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

Nice idea! Looks like there may still be a few instances of failures on AppVeyor?

@nipunn1313
Copy link
Contributor Author

nipunn1313 commented Nov 6, 2016

Looks like cargo read-manifest returns a string with multiple backslashes (like src\foo.rs) which doesn't match the src[/]foo.rs (previously matching src[..]foo.rs). Perhaps this is a bug in cargo read-manifest to output the double backslash? Or an odd intended behavior? For now, I reverted converting the read-manifest test.

@alexcrichton
Copy link
Member

@bors: r+

Huh, odd!

@bors
Copy link
Contributor

bors commented Nov 7, 2016

📌 Commit 2435936 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Nov 7, 2016

⌛ Testing commit 2435936 with merge 0682ced...

bors added a commit that referenced this pull request Nov 7, 2016
Add a [/] macro expansion for tests

Converts to backslash on windows. Currently, we're using [..],
so this will tighten up the tests.
@bors
Copy link
Contributor

bors commented Nov 7, 2016

☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64
Approved by: alexcrichton
Pushing 0682ced to master...

@bors bors merged commit 2435936 into rust-lang:master Nov 7, 2016
@nipunn1313 nipunn1313 deleted the slash branch August 6, 2021 18:01
@ehuss ehuss added this to the 1.14.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants