Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --message-format JSON when rustc emits non-JSON warnings #3410

Merged
merged 2 commits into from
Dec 19, 2016

Commits on Dec 15, 2016

  1. Fix --message-format JSON when rustc emits non-JSON warnings

    The `--message-format JSON` flag parses all the stderr output of rustc to JSON,
    but rustc can emit non-JSON lines to stderr (e.g., for warning about the
    unstable `-Z` flag on the stable channel), causing cargo to fail reporting
    compilation errors when using `--message-format JSON`.
    
    This commit adds a check to look for lines beginning with `{` to only parse
    these lines as JSON.  Other lines from rustc are forwarded to the stderr of
    cargo.
    
    Fixes rust-lang#3390.
    fmdkdd committed Dec 15, 2016
    Configuration menu
    Copy the full SHA
    853db74 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2016

  1. Configuration menu
    Copy the full SHA
    3e32503 View commit details
    Browse the repository at this point in the history